Skip to content

fix(mcp): tighten ingest traces schema for strict clients#757

Open
SyntaxSawdust wants to merge 1 commit into
DeusData:mainfrom
SyntaxSawdust:codex/issue-731-vs-schema
Open

fix(mcp): tighten ingest traces schema for strict clients#757
SyntaxSawdust wants to merge 1 commit into
DeusData:mainfrom
SyntaxSawdust:codex/issue-731-vs-schema

Conversation

@SyntaxSawdust

Copy link
Copy Markdown

Summary

  • Declare supported ingest_traces item fields in the generated MCP schema.
  • Set traces.items.additionalProperties to false for strict clients such as Visual Studio Copilot.
  • Add a parsed tools/list regression test covering the nested schema path.

Why

Fixes #731.

Visual Studio Copilot rejects codebase_memory_ingest_traces because the nested trace item object schema does not explicitly set additionalProperties: false. The schema now closes that object while still advertising the existing trace payload shape: caller, callee, and optional count.

Tests

  • build/c/test-runner mcp - passed, 122 tests.
  • git diff --check - passed.
  • make -f Makefile.cbm test - built and ran, but failed outside the MCP path with local listener/offline clone environment failures.
  • make -f Makefile.cbm lint-ci - blocked locally because cppcheck is not installed.

Scope

  • No runtime trace ingestion behavior changes.
  • No tool names or handler dispatch changes.
  • No manual Visual Studio smoke test was performed.

Signed-off-by: Dustin Persek <dustin.persek@protonmail.com>
@SyntaxSawdust SyntaxSawdust marked this pull request as ready for review July 2, 2026 04:31
@SyntaxSawdust SyntaxSawdust requested a review from DeusData as a code owner July 2, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Add support for Visual Studio GitHub Copilot for codebase-memory-mcp

1 participant