fix(mcp): tighten ingest traces schema for strict clients#757
Open
SyntaxSawdust wants to merge 1 commit into
Open
fix(mcp): tighten ingest traces schema for strict clients#757SyntaxSawdust wants to merge 1 commit into
SyntaxSawdust wants to merge 1 commit into
Conversation
Signed-off-by: Dustin Persek <dustin.persek@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ingest_tracesitem fields in the generated MCP schema.traces.items.additionalPropertiestofalsefor strict clients such as Visual Studio Copilot.tools/listregression test covering the nested schema path.Why
Fixes #731.
Visual Studio Copilot rejects
codebase_memory_ingest_tracesbecause the nested trace item object schema does not explicitly setadditionalProperties: false. The schema now closes that object while still advertising the existing trace payload shape:caller,callee, and optionalcount.Tests
build/c/test-runner mcp- passed, 122 tests.git diff --check- passed.make -f Makefile.cbm test- built and ran, but failed outside the MCP path with local listener/offline clone environment failures.make -f Makefile.cbm lint-ci- blocked locally becausecppcheckis not installed.Scope