Skip to content

fix(watcher): prune sustained missing roots#738

Open
pcristin wants to merge 1 commit into
DeusData:mainfrom
pcristin:fix/watcher-stale-root-cleanup
Open

fix(watcher): prune sustained missing roots#738
pcristin wants to merge 1 commit into
DeusData:mainfrom
pcristin:fix/watcher-stale-root-cleanup

Conversation

@pcristin

@pcristin pcristin commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Implements the watcher stale-root cleanup discussed in #286:

  • Track consecutive missing project roots in the watcher.
  • Preserve projects through transient missing-root checks, then prune after sustained absence.
  • Delete cached project DB/WAL/SHM files when sustained absence is confirmed.
  • Cover the transient-miss and sustained-cleanup behavior with a regression test.

Fixes #286.
Supersedes #666 after refreshing the branch/title/commit metadata to match the contribution guide.

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects unsigned commits.
  • Tests pass locally (make -f Makefile.cbm test).
  • Lint passes (make -f Makefile.cbm lint-ci).
  • New behavior is covered by a test (reproduce-first for bug fixes).

Validation

  • bash scripts/check-no-test-skips.sh
  • git diff --check
  • make -f Makefile.cbm build/c/test-runner
  • build/c/test-runner was run after rebasing; the watcher regression passed. The full local runner still had unrelated local/environment failures.

Signed-off-by: pcristin <xxxokzxxx@protonmail.com>
@pcristin pcristin requested a review from DeusData as a code owner July 1, 2026 12:31
@DeusData DeusData added bug Something isn't working ux/behavior Display bugs, docs, adoption UX priority/normal Standard review queue; useful PR with ordinary maintainer urgency. labels Jul 1, 2026
@DeusData

DeusData commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Thanks for reopening this as a clean replacement for #666. DCO and CI are green, and the PR now has a cleaner title/body/history. I’ve added the same triage labels and moved this into the maintainer review queue.

@pcristin pcristin force-pushed the fix/watcher-stale-root-cleanup branch from 7e42852 to 2bd8f7b Compare July 2, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority/normal Standard review queue; useful PR with ordinary maintainer urgency. ux/behavior Display bugs, docs, adoption UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Automatic deletion of project when underlying folder is deleted

2 participants