refactor(engine): thread SplittableLeafCompiler through CompileContext#362
Merged
Merged
Conversation
StackedLayerCompiler already takes the bundled CompileContext; give the splittable-leaf compiler the same shape. compile() now takes a CompileContext instead of the five separate state / prepareContext / fragmentContext / nodes / fragments parameters (14 args → 10), unpacking them into the same locals at the top so the body is unchanged. Byte-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#361 introduced
CompileContext(bundling the five always-threadedstate/prepareContext/fragmentContext/nodes/fragmentsparams) and used it inStackedLayerCompiler, butSplittableLeafCompiler(from #360) still took themflat. This gives the two extracted compile collaborators one consistent shape.
What
SplittableLeafCompiler.compile(...)now takes aCompileContextinstead of the fiveseparate params (14 → 10 args), unpacking them into the same local names at the top so
the pagination-loop body is untouched.
LayoutCompilerand thecompile(...)helper inSplittableLeafCompilerTestto build theCompileContext.Tests
./mvnw -f aggregator/pom.xml verify -pl :graph-compose-qa -am— full compile + javadoc gateSplittableLeafCompilerTest: 3 tests, 0 failures (unchanged behaviour, new call shape).Byte-identical — the change is parameter repackaging only; the split loop is unmodified.