refactor(engine): drop the vestigial Component marker interface#354
Merged
Conversation
Component was an empty marker left over from the retired ECS engine — implemented by 16 live value types (Margin, Padding, Anchor, TextStyle, ImageData, …) but consumed as a type nowhere: no bound, parameter, instanceof, collection or Class token references it, so it carries no contract. Remove `implements Component` (and its import) from all 16, then delete the interface and its package-info, emptying and removing the engine.components.core package. A leftover fully-commented-out EntityTest in that package's test tree goes with it. The value types are unchanged otherwise; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Componentis an empty marker interface inherited from the retired ECS engine(#353 removed the runtime; this
removes its last vestige). It is
implements-ed by 16 live value types but neverconsumed as a type anywhere — no type bound, parameter,
instanceof, collectionelement, or
Classtoken references it — so it defines no contract and is pure deadweight on the engine value model.
What
implements Componentand its import from all 16 value types:Margin,Padding,Anchor,ContentSize,TextStyle,Text,BlockTextData,Stroke,ImageData,ImageIntrinsicSize,ComponentColor,BarcodeData,DocumentMetadata,HeaderFooterConfig,PdfProtectionConfig,WatermarkConfig.Componentinterface and itspackage-info, which empties and removesthe
engine.components.corepackage; a leftover fully-commented-outEntityTestinthat package's test tree is removed with it.
The value types are otherwise untouched — same fields, factories, accessors, and
equals/hashCode.Tests
./mvnw -f aggregator/pom.xml verify -pl :graph-compose-qa -am— full multi-modulecompile + javadoc gate + the qa visual/parity byte-identity suite: green. Removing
an unconsumed marker changes no behavior; rendered output is identical.
Componentor
engine.components.core.