fix: pass project and production stack in sample workflows#643
Open
simple-agent-manager[bot] wants to merge 1 commit into
Open
fix: pass project and production stack in sample workflows#643simple-agent-manager[bot] wants to merge 1 commit into
simple-agent-manager[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Portal PR DefangLabs/portal#901 creates the BYOC Fabric stack before cloning a sample, but the generated sample workflow still invoked defang-github-action without a project and with an empty stack on push. For samples like sveltekit, the CLI derived the Compose project name from compose.yaml and then fell back to playground when it could not load the repo-named Fabric stack.
With this workflow change, the initial template-generated push uses project=${{ github.event.repository.name }} and stack=production, matching the stack Portal creates before cloning.
Test