Skip to content

fix: pass project and production stack in sample workflows#643

Open
simple-agent-manager[bot] wants to merge 1 commit into
mainfrom
sam/httpsgithubcomdefanglabsportalpull901-doesnt-seem-01kvb3
Open

fix: pass project and production stack in sample workflows#643
simple-agent-manager[bot] wants to merge 1 commit into
mainfrom
sam/httpsgithubcomdefanglabsportalpull901-doesnt-seem-01kvb3

Conversation

@simple-agent-manager

Copy link
Copy Markdown

Summary

  • pass the generated repo name as the Defang project in sample template workflows
  • default sample template deploys to the production stack instead of an empty stack input
  • add a workflow generator regression test so the project/stack inputs stay in the canonical template

Why

Portal PR DefangLabs/portal#901 creates the BYOC Fabric stack before cloning a sample, but the generated sample workflow still invoked defang-github-action without a project and with an empty stack on push. For samples like sveltekit, the CLI derived the Compose project name from compose.yaml and then fell back to playground when it could not load the repo-named Fabric stack.

With this workflow change, the initial template-generated push uses project=${{ github.event.repository.name }} and stack=production, matching the stack Portal creates before cloning.

Test

  • npm test (projects/samples/scripts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant