Repository navigation
feat: @cucumber/cucumber 13 (0.1.6) - #20
Merged
Merged
Conversation
Cucumber 13 runs --parallel workers as worker threads, which don't get the tsx loader cucumber.mjs registers, so every test script sets NODE_OPTIONS='--import tsx'. engines node >=22 (cucumber 13 dropped Node 20). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alexanderilyin
added a commit
to DeepSpaceCartel/devcontainer-builder
that referenced
this pull request
Oct 7, 2026
- Sentry 11's fastifyIntegration captures errors itself and setupFastifyErrorHandler is deprecated: the call is gone. - TypeScript 7 no longer loads @types/* on its own: tsconfig lists node. - thomas 0.1.6 (DeepSpaceCartel/thomas#20) accepts cucumber 13, whose --parallel workers are threads; npm test already sets NODE_OPTIONS='--import tsx', which reaches them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cucumber/pretty-formatter 4.x no longer exports a class-based formatter, so --format @cucumber/pretty-formatter fails under cucumber 13. Use the built-in 'pretty' formatter and drop the redundant devDependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Helm v4.3 spells it 'reuse' (v3: 're-use'), so assert only the shared tail 'name that is still in use'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BuildKit needs a privileged pod, which the cluster's default baseline PodSecurity level rejects. The namespace label was a manual one-time step and was lost when thomas-helm-test got recreated. Each Docker scenario now sets pod-security.kubernetes.io/enforce=privileged before installing BuildKit and removes it after uninstalling. CI needs a ClusterRole to patch that one namespace (documented in docs/project/ci.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Labeling thomas-helm-test needs cluster-scoped access the CI ServiceAccount doesn't have; skip them in CI instead of adding a ClusterRole for now. They still run for anyone with broader access. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the global real-tests group on the test job (one shared namespace) but add a per-ref workflow group that cancels a PR's older run, so a stale commit no longer holds the only slot. main is never cancelled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
engines node >=26 and @types/node ^26 to match the dev container's Node 26; every workflow reads the version from a new .nvmrc instead of hard-coding "22". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Node 26's Linux binary needs libatomic.so.1, which the ARC runner image lacks, so real-tests died before running any scenario. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets devcontainer-builder take cucumber 13 (DeepSpaceCartel/devcontainer-builder#67).
@cucumber/cucumber^13.2.1; version 0.1.6;enginesnode >=22.--parallelworkers are worker threads, andregister()incucumber.mjsdoesn't reach them (ERR_MODULE_NOT_FOUNDon a.tsimport). Everytest*script now setsNODE_OPTIONS='--import tsx', which they do get.CUCUMBER_WORKER_IDis still set per worker (cucumber'sadapter.ts), so per-worker namespaces and log names are unchanged.Verified:
tsc --noEmitis clean, and devcontainer-builder'srequest_validation.featureran on Node 26 with--parallel=3up to its image build (which needs this commit pinned).🤖 Generated with Claude Code