Repository navigation
test(bdd): delete the pre-Thomas .js support and step files nothing loads - #62
Merged
Merged
Conversation
…oads cucumber.mjs imports features/support/**/*.ts and features/step_definitions/**/*.ts, and every file there was .js, from the 'Experiments with BDD' commit before the suite moved to Thomas - so none of them (timeouts, World, the cli/common/request_validation steps, the optional teardown hook keyed to the old cli step) ever ran. Thomas provides every step the features use. Deleting them changes nothing at runtime; docs/project/testing.md's suggestion is marked done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the coverage work (#61):
cucumber.mjsimports onlyfeatures/support/**/*.tsandfeatures/step_definitions/**/*.ts, but every file there was.js, left over from before the suite moved to Thomas (the "Experiments with BDD" commit). None of them ever ran:Thomas provides every step the features use; the BDD runs pass without these files. Deleting them changes nothing at runtime. The
testing.mdsuggestion is marked done.🤖 Generated with Claude Code