Repository navigation
meta: bring verify-kawa up to date with master - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verify-kawa skill was written before most of what kawa does now existed, so its feature map was missing layer shell, activation, Xwayland selections, popups, presentation, and most of the window management, and a few of its instructions no longer matched the code. Every feature in the map was driven against a fresh build of master to check it.
The map gains files for window management, activation and attention, layer shell, popups, Xwayland, and presentation with GTK 4. The existing ones are corrected: the baseline is master, a right-press on a window border starts a move rather than opening the menu, the New box stays up until the window maps or the program exits, a late window takes the box and focus,
fillletterboxes rather than crops, and the bar follows title changes.The harness changes are mostly about running on a fresh X server alongside other sessions. launch.sh now requires DISPLAY instead of guessing one, creates the atoms the X11 backend names its window with (without them the window stays untitled on a new Xvfb and screenshots fail), starts a private D-Bus session so GTK clients don't share an autolaunched bus, and builds a small xdg-activation client. doctor.sh checks that kawa's window is there. cleanup.sh also stops leftover processes from the run, unmounts the document portal, and removes the X lock and socket Xwayland leaves behind. new-cmd.sh lets one instance start a different program from New each time and keeps its output, which kawa otherwise throws away.
A few things look like bugs in kawa itself and are noted as gotchas rather than worked around: a hidden window keeps keyboard focus,
-bgscale fitputs a small image at the top-left corner under the bar, an exclusive-keyboard layer surface that maps while a popup grab is open never gets the keyboard, and clicking empty desktop does not dismiss popups.