Skip to content

Incompatibility with upcoming duckdb 1.5.2 #17

Closed

Description

@krlmlr

Test results in this package change with duckdb/duckdb-r#2231 , not sure if for the better or for the worse. I reverted it for the v1.5.1 release but would like to get this into v1.5.2.

@DavZim: Can you please help? Thanks!

Activity

  1. DavZim commented on Mar 24, 2026

    @DavZim
    Owner

    Interesting. I don't use any duckdb directly but use dbplyr behind the scenes for conversion between r/dplyr code and SQL.

  2. changed the title [-]Incompatibility with upcoming duckdb 1.5.1[/-] [+]Incompatibility with upcoming duckdb 1.5.2[/+] on Mar 24, 2026
  3. krlmlr commented on Mar 26, 2026

    @krlmlr
    Author

    I pushed duckdb/duckdb-r@7701c4ad5 . This will appear in r-universe in a few hours, for easy installation of binaries.

    Previously, as.numeric() and friends threw an error if conversion was not possible. With this change, it silently returns NULL , without a warning.

  4. DavZim commented on Mar 26, 2026

    @DavZim
    Owner

    Ah, I think I understand where the error might come from. I'll try to have a look later.

  5. DavZim commented on Mar 27, 2026

    @DavZim
    Owner

    I found the issue and a fix.
    However, the tests are different between duckdb on CRAN and the current r-universe duckdb version 1.5.1 (or is it 1.5.2?).

    Is there any timeline when the new version will hit CRAN?

  6. DavZim commented on Mar 27, 2026

    @DavZim
    Owner

    This is closed with 2118754.

  7. krlmlr commented on Mar 27, 2026

    @krlmlr
    Author

    Thanks for the heads-up. A skip_if_not_installed("duckdb", "1.5.2") in this particular test would help make this work with old and new duckdb.

    The other diff contains spurious EOL changes. Do you need to normalize line endings?

  8. krlmlr commented on Mar 27, 2026

    @krlmlr
    Author

    r-universe should update to 1.5.1.9000 soon. Upstream DuckDB is scheduled on April 13. Would you be able to submit to CRAN before that date?

  9. DavZim commented on Mar 27, 2026

    @DavZim
    Owner

    That should be possible.
    I implemented a couple of other features today, so I need to publish to cran anyways...
    Is it possible for you to give a quick ping once the r universe is updated? Then I will test it again

  10. DavZim commented on Mar 27, 2026

    @DavZim
    Owner

    Yeah, I messed up the white spaces... Will need to fix that as well...

  11. DavZim commented on Apr 10, 2026

    @DavZim
    Owner

    #18 fixed the incompatibility issues (tested with duckdb 1.5.1.9002).
    Package is submitted to CRAN.
    Ill close this for now and will reopen if there are any other issues coming up.
    Thanks for the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions