test(otlp-trace-metrics): fix Java compatibility checks - #7466
Draft
mabdinur wants to merge 1 commit into
Draft
Conversation
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7363 based on validation against DataDog/dd-trace-java#12144.
KeyError: resourceMetricsbefore the assertions can inspect received metrics.1fordatadog.span.top_levelintest_fr08_13_is_trace_root, matching the existing FR08 assertions and Java wire format. The threedatadog.is_trace_rootvalues were already correct./inforesponse with adb.hostnamepeer-tag allowlist, wait for the tracer to consume it, and mark the test span as client-kind. This exercises Java peer-tag capture instead of an ineligible internal span.Validation
test_fr08_13_is_trace_rootandtest_fr08_14_peer_tagsboth passtest_fr01_6_disabled_when_apm_tracing_disablednow reaches its intended assertion and confirms a remaining Java implementation gap: OTLP span metrics are still emitted when APM tracing is disabled.Draft while the OTEL specification and Java implementation are finalized.