Skip to content

Review rule for deactivating scenarios in weblog metadata files - #7463

Merged
nccatoni merged 1 commit into
mainfrom
nccatoni/scenario-deactivation-review-rule
Aug 5, 2026
Merged

Review rule for deactivating scenarios in weblog metadata files#7463
nccatoni merged 1 commit into
mainfrom
nccatoni/scenario-deactivation-review-rule

Conversation

@nccatoni

@nccatoni nccatoni commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@nccatoni
nccatoni marked this pull request as ready for review August 5, 2026 14:31
@nccatoni
nccatoni requested a review from a team as a code owner August 5, 2026 14:31
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.cursor/rules/pr-review.mdc                                             @DataDog/system-tests-core

@nccatoni
nccatoni merged commit d8f53d6 into main Aug 5, 2026
15 checks passed
@nccatoni
nccatoni deleted the nccatoni/scenario-deactivation-review-rule branch August 5, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant