Skip to content

Add scenario duplicates for dd-trace-java with forced v1 protocol - #7439

Draft
AlexeyKuznetsov-DD wants to merge 9 commits into
mainfrom
alexeyk/default-v1-protocol-tests
Draft

Add scenario duplicates for dd-trace-java with forced v1 protocol#7439
AlexeyKuznetsov-DD wants to merge 9 commits into
mainfrom
alexeyk/default-v1-protocol-tests

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Motivation

Validate the v1 trace intake protocol in system-tests before it becomes the Java tracer default. The coverage should exercise the shared DEFAULT suite across Java weblogs and a representative complete weblog matrix without introducing a tracer-agnostic scenario.

Changes

  • Duplicate Java prod jobs containing DEFAULT, keep only the DEFAULT scenario in those copies, and suffix their job instance with _v1.
  • Duplicate all three spring-boot-jetty CI shards (1_v1, 2_v1, and 3_v1) with their complete scenario lists.
  • Pass per-job weblog environment overrides through the reusable end-to-end workflow.
  • Force DD_TRACE_AGENT_PROTOCOL_VERSION=1.0 in the duplicated jobs.
  • Remove the dedicated DEFAULT_V1 scenario and its special test-selection/framework handling.
  • Remove the obsolete DD_APM_ENABLE_V1_TRACE_ENDPOINT setting from APM_TRACING_EFFICIENT_PAYLOAD; current Agents expose the v1 endpoint by default.

Impact

The additional coverage is restricted to Java prod jobs. Java dev and all other tracers keep their existing matrices unchanged.

Validation

  • ./run.sh TEST_THE_TEST tests/test_the_test/test_ci_orchestrator.py tests/test_the_test/test_docker_scenario.py::test_load_environment_overrides tests/test_the_test/test_build_pipeline.py tests/test_the_test/test_gitlab_pipeline_structure.py — 23 passed.
  • Focused Ruff and mypy checks passed.
  • YAML formatting, yamllint, and workflow parser checks passed.
  • The repository-wide formatter reaches an unrelated existing failure in utils/scripts/shellcheck.sh:74 (@: unbound variable) after the relevant checks pass.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on your PR until the CI passes.
  3. Mark it as ready for review:
    • Test logic is modified → get a review from the RFC owner.
    • Framework is modified, or usage is non-obvious → get a review from the R&P team.

🚀 Once the PR is reviewed and CI is green, it can be merged.

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified: approval from the R&P team.
  • A Docker base image is modified: the relevant build-XXX-image label is present.
  • A scenario is added, removed, or renamed: get a review from the R&P team.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
.github/workflows/system-tests.yml                                      @DataDog/system-tests-core
tests/test_the_test/test_ci_orchestrator.py                             @DataDog/system-tests-core
tests/test_the_test/test_docker_scenario.py                             @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/endtoend.py                                   @DataDog/system-tests-core
utils/scripts/ci_orchestrators/workflow_data.py                         @DataDog/system-tests-core

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 11 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #2 / laravel11x 2   View in Datadog   GitHub Actions

See error Unable to find jUnit XML report files for test results upload.

🧪 1 Test failed

tests.stats.test_stats.Test_Peer_Tags.test_peer_tags[laravel11x] from system_tests_suite   View in Datadog
AssertionError: Client spans should have peer tags, found: []
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Peer_Tags object at 0x7f2ec56b8ef0>

    def test_peer_tags(self):
        """Test that client spans include peer tags while server spans don't"""
        client_stats_found = False
        server_stats_found = False
...

DataDog/system-tests | K8S_LIB_INJECTION_PROFILING_ENABLED: [dd-lib-java-init-test-app, ${PRIVATE_DOCKER_REGISTRY}/system-tests/dd-lib-java-init-test-app, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/cluster-agent:7.81.1, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/apm-inject:latest, 3.231.5, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/dd-lib-java-init:latest]   View in Datadog   GitLab

DataDog/system-tests | K8S_LIB_INJECTION_PROFILING_ENABLED: [dd-lib-java-init-test-app, ${PRIVATE_DOCKER_REGISTRY}/system-tests/dd-lib-java-init-test-app, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/cluster-agent:7.81.1, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/apm-inject:latest, 3.231.5, 235494822917.dkr.ecr.us-east-1.amazonaws.com/ssi/dd-lib-java-init:latest_snapshot]   View in Datadog   GitLab

View all 11 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 0 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4e67249 | Docs | Datadog PR Page | Give us feedback!

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the title Add DEFAULT_V1 scenario for Java and Go Add DEFAULT_V1 scenario for tracers that support v1 protocol, but not yet use it by default Aug 3, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD force-pushed the alexeyk/default-v1-protocol-tests branch from 3b4ecdc to ef40c24 Compare August 5, 2026 19:55
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the title Add DEFAULT_V1 scenario for tracers that support v1 protocol, but not yet use it by default Add scenarios duplicates for dd-trace-java with forced v1 protocol. Aug 5, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the title Add scenarios duplicates for dd-trace-java with forced v1 protocol. Add scenario duplicates for dd-trace-java with forced v1 protocol Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant