Repository navigation
[DATASEC-498] Add token-efficiency-checker feature to drop tiktoken-rs - #402
Merged
Merged
Conversation
aimenebelfodil
marked this pull request as ready for review
October 22, 2026 12:33
aimenebelfodil
force-pushed
the
aimene.belfodil/datasec-498/add-feature
branch
from
October 22, 2026 12:35
80b6f67 to
81514e6
Compare
aimenebelfodil
changed the base branch from
main
to
aimene.belfodil/fix-rustls-webpki-advisory
October 22, 2026 12:36
Base automatically changed from
aimene.belfodil/fix-rustls-webpki-advisory
to
main
October 22, 2026 12:38
Co-authored-by: Cursor <cursoragent@cursor.com>
aimenebelfodil
force-pushed
the
aimene.belfodil/datasec-498/add-feature
branch
from
October 22, 2026 12:38
81514e6 to
fc3ac39
Compare
aimenebelfodil
changed the title
fuchsnj
approved these changes
Oct 22, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This pull request was merged directly. |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a default-on
token-efficiency-checkerCargo feature that gatesTokenEfficiencyCheckandNonHexPlusTokenEfficiencyCheckersecondary validators.Motivation
Add the capability to build a leaner dependency, by letting consuming libraries accept dropping these secondary validators.
Describe how you validated your changes
make check-rustwhich runscargo hack check/clippy --each-featurecovering the case where we build without the feature.Additional Notes
Consumers using
default-features = falsemust addtoken-efficiency-checkerto keep these validators.