Repository navigation
Simplify Scope into a single include/exclude struct - #399
Merged
Merged
Conversation
fuchsnj
approved these changes
Oct 21, 2026
fuchsnj
left a comment
fuchsnj
left a comment
Contributor
There was a problem hiding this comment.
Approving with small comment suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the
Scopeenum with a struct:include(newScanArea, eitherEverythingorOnly(paths)) andexclude. Theall/include/exclude/include_and_excludeconstructors keep their signatures and scan behavior is unchanged.The scope JSON changes to
{"include":"everything","exclude":[...]}/{"include":{"only":[...]},"exclude":[...]}. Old-format JSON is now rejected instead of being read as "scan everything".Motivation
Main motivation is to improve code clarity of scope.rs. Should simplify future maintenance work without actually changing anything related to the functionality of scopes in SDS.
Describe how you validated your changes
Additional Notes
SDSP-477
sds-shared-library writes scope JSON from its Java and Go bindings, so it needs the matching update in ddoghq/sds-shared-library#2094 when it bumps to this version.