Feature/actions windows 2025#41
Closed
ecenshu wants to merge 5 commits into
Closed
Conversation
Collaborator
Author
|
Forgot to squash commits |
Owner
I know I mentioned doing this before, but I only meant to do that during that huge merge you wanted to do that had a massive # of commits, and was coming from your repo. When it's only a few commits (like this was), I'd actually prefer not to squash the commits because it can be helpful to have more granularity in terms of the changes that were made in each commit. |
Collaborator
Author
|
I'll only squash commits in future if the pull request contains multiple
functions then. I usually attempt to do one functionality at a time per
feature branch.
…On Thu, 2 Oct 2025 at 09:13, Dasmius007 ***@***.***> wrote:
*Dasmius007* left a comment (Dasmius007/HumbleKeysLibrary#41)
<#41 (comment)>
@ecenshu <https://github.com/ecenshu>
Forgot to squash commits
I know I mentioned doing this before, but I only meant to do that during
that huge merge you wanted to do that had a massive # of commits, and was
coming from your repo. When it's only a few commits (like this was), I'd
actually prefer not to squash the commits because it can be helpful to have
more granularity in terms of the changes that were made in each commit.
—
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2BEJQEZK3EXDUAIPOYPBL3VRRKTAVCNFSM6AAAAACH6VDI76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJYGUZTENBUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
@ecenshu Sounds good, thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated actions container from windows-2019 to windows-2025
Also allow for beta branches to trigger actions workflow