Repository navigation
docs(payload): audit configuration safety and reproducibility - #117
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Darkroom4364
force-pushed
the
codex/issue-65-config-audit
branch
from
July 27, 2026 11:17
70ae398 to
2dd7e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
Changes
docs/payload-builds.md.readEffectiveBuildConfigcoverage inserver/internal/handlers/api/payload/build_contract_test.gofor a credential-free control plus credential-key and raw-credential-byte rejection.Boundary
No production behavior or runtime override was added. Effective config must match the build payload/listener/mutation seed; protocol is independently restricted to
http/https; credentials are stripped or rejected beforeconfig.jsonand provenance publication.Validation
go test -count=1 -run '^TestReadEffectiveBuildConfigRejectsCredentialMaterial$' ./internal/handlers/api/payloadinserver/go test ./...inserver/go vet ./...inserver/