Repository navigation
Harden Windows/Linux parity and gate packages on Windows CI - #52
Merged
Merged
Conversation
…m-parity-pr # Conflicts: # src/isycode/action_audit.py # src/isycode/iteration.py # src/isycode/tui.py # tests/test_grok_auth_tui.py # tests/test_quick_start.py
DannyBaanks
added a commit
that referenced
this pull request
Oct 16, 2026
…ariant Merges codex/windows-platform-parity-pr (21 commits, CrossPlatform-Parity method) into post-remediation main. 5 conflicts resolved: - action_audit.py: the two branches fixed F-03 (verify-under-write race) independently — main with POSIX flock on the data file, parity with a cross-platform SIDECAR lock (held in _append, survives os.replace). Unified on the sidecar: writer keeps held() in _append (fchmod inside), reader now holds the same sidecar during its two fstats; POSIX LOCK_SH kept as defense in depth; storage.ensure_directory/private adopted for cross-platform dir creation and ACL checks; StateIndex stays the path authority (M7). Race x200 + tamper tests green (19 passed). - iteration.py: storage import restored next to get_state_index. - tui.py: dropped parity branch's stale in-body copies (pre-M8 layout); ported its three real deltas: asyncio.to_thread for the two blocking choose_recurrent writes, await push_screen (modal mount race, Windows), and the authority_settings sizing in _size_action_menu (now in MenuMixin per M8). - test_grok_auth_tui.py: wait_for_ready (M2) replaces the hand-rolled worker-group wait — the convergence the briefing predicted. - test_quick_start.py: kept the readiness-park design; removed the incompatible stub/restore block; restored _clear_saved_recurrence + json. m15-authority-coverage.json regenerated via the canon generator (post- merge constructor lines). Suite: 2054 passed, 127 skipped (Windows platform matrix, reasons declared per the CrossPlatform-Parity method), 11 deselected; 1 known pre-existing flake (file_preview_tui under full load; passes standalone). validate_gates --require-approved: 9 release-blocked (unchanged, human approval pending on the classic-security-ux roadmap) + 3 new sha256 mismatches created by this merge itself (test_gate_validator, test_workspace_trust in two M4 evidence gates) — evidence rot (global vice #3) reproduced during the merge; those gates need regeneration, not manual patching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios
Verificación
df3e91fpasó en los eventos PR y push: suites Linux 3.10, Linux con Textual 8 y Windows (seis suites en total).linux-x86_64,macos-arm64ywindows-x86_64pasaron en ambos eventos; el paso de borrador de release se omitió.Aceptación pendiente
La matriz de cinco usuarios se excluye por solicitud del usuario. NATIVE_ACCEPTED=False sigue vigente. Continúan NOT_DEMONSTRATED: ACL con otra cuenta iniciada separadamente, casos IPC/dispositivo restantes, staging de runtimes/dependencias, recuperación ante pérdida eléctrica y paridad interactiva física Linux/Windows. La consulta del updater empaquetado sí quedó demostrada; reemplazar en sitio un EXE/AppImage congelado no forma parte de ese comportamiento compartido.