Repository navigation
[arch] del: remove unused HaltDPI leftover - #138
Open
shirohasuki wants to merge 3 commits into
Open
shirohasuki wants to merge 3 commits into
shirohasuki wants to merge 3 commits into
Conversation
HaltDPI.sv is gone; dpi_sim_halt in halt.cc/h has no callers. BuckyballRawCmd was an unused RoCCCommandBB wrapper in GlobalDecoder.
shirohasuki
requested a deployment
to
regression
October 4, 2026 08:46 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
shirohasuki
requested a deployment
to
regression
October 6, 2026 07:58 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
shirohasuki
changed the title
shirohasuki
requested a deployment
to
regression
October 10, 2026 07:52 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused HaltDPI leftover:
arch/src/csrc/include/monitor/halt.handarch/src/csrc/src/monitor/trace/halt.cc— comments say they are called fromHaltDPI.sv, but that SV (and anydpi_sim_haltimporter) is gone. Verilator still globs allarch/src/csrc/**/*.cc, so this also drops a dead object from BBSim builds.(
BuckyballRawCmdwas originally part of this PR; main has since removed it, so the branch now only carries the halt files.)Verification
rg/git grepforHaltDPI,dpi_sim_halt,halt.h,halt.ccon latest main: only the deleted files themselvescd arch && mill -i buckyball.compile