Skip to content

fix: terminate detached descendants on bbdev cancellation - #20

Merged
daiyongyuan merged 2 commits into
mainfrom
fix/bbdev-process-tree-cleanup
Sep 24, 2026
Merged

daiyongyuan merged 2 commits into
mainfrom
fix/bbdev-process-tree-cleanup

Conversation

@daiyongyuan

@daiyongyuan daiyongyuan commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Terminate the complete subprocess tree when a bbdev task is cancelled, shut down, or times out.
  • Clean up descendants that start a separate session, such as detached FPGA flashing tools.

Validation

  • api/.venv/bin/python -m unittest api.unit_tests.test_process_cleanup -v (2 tests passed)
  • git diff --check

import signal
import subprocess
import sys
import tempfile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests under api/tests are for bbdev API testing and demonste how to use them; please read the unified format in other tests.

@daiyongyuan
daiyongyuan merged commit 30d1abe into main Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants