Repository navigation
Build the Nix flake in CI, document NixOS, fix qmllint on Qt 6.12 - #36
Merged
Merged
Conversation
qmllint in Qt 6.12 reports an id that has the same name as a property of the object it is assigned to (id-shadows-member). quick-check runs qmllint with -W 0, so the Arch package build, which now gets Qt 6.12, failed on five test doubles such as `controller: controller`. Name them with the Mock suffix the other QML tests already use.
Build the flake added in #33 with a pinned install-nix-action and check that its output has both binaries at the release version, the runtime, the udev rules, the user unit pointing at the store path with KillMode=mixed, and an ffmpeg with libx264 on the runtime's PATH. Tagged releases skip the job, so a change in nixpkgs cannot block a release build.
Add the flake input and the NixOS configuration that enables the package, its udev rules and the user service, based on the configuration the flake contributor tested with a display.
The Panorama layout test has the same shadowing ids. Qt 6.12 qmllint did not print its warnings when it linted all files together and only exited with 255, so the first fix missed it. All QML files now lint clean with Qt 6.12 qmllint -W 0, and the QML tests pass under Qt 6.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #33.
id-shadows-member).quick-checkruns qmllint with-W 0, so the Arch package build failed on five QML test doubles likecontroller: controller, on every branch. The doubles now use theMocksuffix the other QML tests already use; component properties are unchanged.nixjob inpackage-linux.ymlbuilds the flake with a pinnedcachix/install-nix-actionand checks the output: both binaries at the release version, the runtime, the udev rules, the user unit with the storeExecStartandKillMode=mixed, and an ffmpeg withlibx264on the runtime'sPATH. Tagged releases skip it, so a change in nixpkgs cannot block a release build.Checks: the Qt Quick suite passes locally on Qt 6.11; the Arch job in this PR verifies the Qt 6.12 fix and the new job verifies the flake.