Skip to content

fix(variants): real slicer metadata, UTF-16 entity refusal, bounded footer summaries (draft, Codex lane) - #149

Draft
DVOpenLabs wants to merge 2 commits into
mainfrom
codex/variants-slicer-metadata
Draft

DVOpenLabs wants to merge 2 commits into
mainfrom
codex/variants-slicer-metadata

Conversation

@DVOpenLabs

Copy link
Copy Markdown
Owner

Variants repair lane implemented by Codex, reviewed by Opus and Sol on the exact tree 71caef9009537fb3119267d70746f33fd957d4d2 (APPROVE-WITH-NOTES from both; delta over be26d0f, whose Sol BLOCK on BOM-less UTF-16 XML entities is closed).

What changed (5 files): Orca/Bambu XML plate summaries aggregate by filament id, incomplete usage/time stay unknown; XML is UTF-8 only with DTD/entity refusal (decoded-NUL guard covers BOM-less UTF-16/UTF-32); bounded G-code head + footer summaries keep tool counts unknown when truncated; footer CONFIG settings share one allowlist; malformed later grams do not erase known grams; normal time beats silent mode; late result/error invalidation in the route.

Verified by Codex (Windows, Python 3.14): full backend 5444 passed / 53 skipped, desktop 1529 passed, tsc + build pass, synthetic UI capture. Not run: POSIX/3.13/CI (this PR's CI is the first), real Orca/Bambu slice_info.config or G-code (format assumptions are not fixture-verified), hardware.

Open optional notes: V-04 test gaps (Orca-shaped XML with declaration/BOM, empty plate, >256 plates, scan boundary, UTF-32, unmount); settings outside the scanned head/tail windows can still show as differences; settings precedence in the body; a plate with no <filament> makes totals unknown (unvalidated against real Orca output).

Base: integ/demo-20261102 (#144). Not merged; main does not yet contain the Variants track.

🤖 Generated with Claude Code

DVOpenLabs and others added 2 commits November 14, 2026 12:44
…ooter summaries

Orca/Bambu XML plate summaries aggregate by filament id with incomplete usage/time unknown; XML is UTF-8 only and DTD/entity content is refused, including BOM-less UTF-16/UTF-32 via a decoded-NUL guard; bounded G-code head and footer summaries keep tool counts unknown when truncated; footer CONFIG settings use the same allowlist; malformed later grams do not erase known grams; normal time beats silent mode; late result/error invalidation in the route.

Verified (Codex, Windows, Python 3.14): full backend 5444 passed / 53 skipped, desktop 1529 passed, tsc + build pass. Reviewed: Opus and Sol APPROVE-WITH-NOTES on tree 71caef9 (delta over be26d0f whose Sol BLOCK is closed). Open optional notes: V-04 test gaps, footer-window settings asymmetry beyond 256 KiB, settings precedence.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Base automatically changed from integ/demo-20261102 to main November 14, 2026 19:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant