Repository navigation
fix(variants): real slicer metadata, UTF-16 entity refusal, bounded footer summaries (draft, Codex lane) - #149
Draft
DVOpenLabs wants to merge 2 commits into
Draft
DVOpenLabs wants to merge 2 commits into
DVOpenLabs wants to merge 2 commits into
Conversation
…ooter summaries Orca/Bambu XML plate summaries aggregate by filament id with incomplete usage/time unknown; XML is UTF-8 only and DTD/entity content is refused, including BOM-less UTF-16/UTF-32 via a decoded-NUL guard; bounded G-code head and footer summaries keep tool counts unknown when truncated; footer CONFIG settings use the same allowlist; malformed later grams do not erase known grams; normal time beats silent mode; late result/error invalidation in the route. Verified (Codex, Windows, Python 3.14): full backend 5444 passed / 53 skipped, desktop 1529 passed, tsc + build pass. Reviewed: Opus and Sol APPROVE-WITH-NOTES on tree 71caef9 (delta over be26d0f whose Sol BLOCK is closed). Open optional notes: V-04 test gaps, footer-window settings asymmetry beyond 256 KiB, settings precedence. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variants repair lane implemented by Codex, reviewed by Opus and Sol on the exact tree
71caef9009537fb3119267d70746f33fd957d4d2(APPROVE-WITH-NOTES from both; delta overbe26d0f, whose Sol BLOCK on BOM-less UTF-16 XML entities is closed).What changed (5 files): Orca/Bambu XML plate summaries aggregate by filament id, incomplete usage/time stay unknown; XML is UTF-8 only with DTD/entity refusal (decoded-NUL guard covers BOM-less UTF-16/UTF-32); bounded G-code head + footer summaries keep tool counts unknown when truncated; footer CONFIG settings share one allowlist; malformed later grams do not erase known grams; normal time beats silent mode; late result/error invalidation in the route.
Verified by Codex (Windows, Python 3.14): full backend 5444 passed / 53 skipped, desktop 1529 passed, tsc + build pass, synthetic UI capture. Not run: POSIX/3.13/CI (this PR's CI is the first), real Orca/Bambu
slice_info.configor G-code (format assumptions are not fixture-verified), hardware.Open optional notes: V-04 test gaps (Orca-shaped XML with declaration/BOM, empty plate, >256 plates, scan boundary, UTF-32, unmount); settings outside the scanned head/tail windows can still show as differences; settings precedence in the body; a plate with no
<filament>makes totals unknown (unvalidated against real Orca output).Base:
integ/demo-20261102(#144). Not merged; main does not yet contain the Variants track.🤖 Generated with Claude Code