Skip to content

fix(calibration): real DitherForge/Kromacut palette inputs, refuse conflicting TD (draft, Codex lane) - #148

Closed
DVOpenLabs wants to merge 2 commits into
mainfrom
codex/calibration-real-inputs
Closed

DVOpenLabs wants to merge 2 commits into
mainfrom
codex/calibration-real-inputs

Conversation

@DVOpenLabs

Copy link
Copy Markdown
Owner

Calibration repair lane implemented by Codex, reviewed by Opus and Sol on the exact tree c5c105250e5c61a56660f51cd0c9408179296565 (APPROVE-WITH-NOTES from both; delta over the earlier tree 8b5bcca4, whose Sol BLOCK CAL-01 and Opus O1/O2 are closed).

What changed (8 files, no schema change): DitherForge bare numeric TD and comments; repeated/malformed/conflicting TD refused; Kromacut v2 colours, names and disabled indices; physical readings start empty and clear on palette/basis change; visible nozzle, material, first layer and model; blank material is a 400 (only an absent key keeps PLA); local history; late import/evaluation guards.

Verified by Codex (Windows, Python 3.14): full backend 5457 passed / 53 skipped, desktop 1531 passed, tsc + build pass, synthetic UI capture. Not run: Python 3.13/POSIX/CI (this PR's CI is the first), hardware colour measurement, slicer round trip.

Open optional notes: deferred-promise tests for out-of-order imports and stale evaluation rejection; an oversize file clears the typed palette before the size check; a second TD-like token in the label is not compared.

Base: integ/demo-20261102 (#144), the tree this lane was built on. Not merged; main does not yet contain the Calibration track.

🤖 Generated with Claude Code

DVOpenLabs and others added 2 commits November 14, 2026 12:41
…nflicting TD, visible basis, local history

DitherForge bare numeric TD and comments; repeated, malformed or conflicting TD refused (unknown stays unknown); Kromacut v2 colours, names and disabled indices; blank initial readings cleared on palette/basis change; visible nozzle, material, first layer and model; blank material is a 400, only an absent key keeps PLA; browsable local history; late import/evaluation guards.

Verified (Codex, Windows, Python 3.14): full backend 5457 passed / 53 skipped, desktop 1531 passed, tsc and build pass. Reviewed: Opus and Sol APPROVE-WITH-NOTES on tree c5c1052 (delta over 8b5bcca). Open optional notes: deferred-promise tests, oversize-import clears typed palette.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

DVOpenLabs added a commit that referenced this pull request Nov 14, 2026
… conflicting TD (approved Codex lane applied onto #140)

Applies the Opus+Sol approved Calibration tree c5c1052 (PR #148) to the #140 branch. Resolves Sol SOL-F1 on the #140 aggregate: the synthetic default physical readings and owned filaments are no longer submitted or saved as observations.

Verified: byte-identical to the approved manifest (8 files); backend calibration 34 passed; desktop 1485 passed; tsc clean.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Base automatically changed from integ/demo-20261102 to main November 14, 2026 19:24
@DVOpenLabs

Copy link
Copy Markdown
Owner Author

Landed on main via #144 (merge 15a2ac3) / #140. Verified: merging this head into main produces a tree identical to main, so nothing here is lost. Branch preserved.

@DVOpenLabs DVOpenLabs closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant