Skip to content

test(crosstrack): P8 test 11 through real entry points, configurable monitoring port (draft, depends on #140) - #142

Closed
DVOpenLabs wants to merge 5 commits into
mainfrom
feat/p8-crosstrack
Closed

DVOpenLabs wants to merge 5 commits into
mainfrom
feat/p8-crosstrack

Conversation

@DVOpenLabs

@DVOpenLabs DVOpenLabs commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Draft for review. Opus APPROVE-WITH-NOTES, Sol APPROVE-WITH-NOTES (no findings in the final round) on this package's final bytes. Depends on #140; do not merge before it. Sol's unresolved BLOCK on #140 (passport export output-directory race, R4-F1) is inherited and still open; the draft-only exception for #140 does not extend to this PR. Merge and release are not authorized.

What

P8 cross-track test 11 on top of #140: creative/Prepare output -> passport identity -> recovery checkpoint -> mutate/delete files -> read-only restore preview, through real entry points (route dispatch, service.convert, the passport CLI module, recovery routes). No hardware replay.

  • Monitoring port is now validated configuration (default 7125, range-checked in backend and UI); read-only restrictions unchanged.
  • Loopback mock MockHost is a request sentinel: it records every verb and path, including verbs without a handler (TRACE, CONNECT, extension verbs). Test 11 asserts exactly the two approved GETs.
  • docs/internal/RECOVERY.md lists what test 11 does not cover (HTTP transport/token, HTTP /convert handler, /creative/prepare, desktop UI, crash/restart; the sentinel sees only its one mock host).
  • Recovery screenshots (synthetic data); capture.mjs refuses to capture if page text or a visible input value shows a local path.

Review

Sol BLOCK B-F1 (fixed in b5c7bb9) and B-R2-F1 (fixed in 2275485) (sentinel gaps), CLOSED at round 3. Opus notes N3 fixed (6366234). Artifact 9c1d7c4e86130f9c60390dcce8a35b94f3ac81fdfd6f180e6f8bb609b64f6de9 (shared with the P2 PR).
Carried, not fixed: Opus F3 (LOW) a request line that fails parsing is never recorded; test 11 does not assert the connection count. Opus F4 (POLISH) the mask exemption checks only computed color. N4/N6 (POLISH).

Evidence labels

fixture-tested and mock-service-tested (loopback only). Python 3.14 locally: last backend run 290 passed (before the capture-only commit 6366234, whose script was run once and passed). Python 3.13 confirmation is CI's.

Known gaps

Sentinel margin cases above; no real printer, no real browser-hardware path, no process crash/restart coverage.

🤖 Generated with Claude Code

DVOpenLabs and others added 4 commits November 1, 2026 09:15
…ing port

Test 11 runs inspect -> Prepare -> passport CLI verify -> recovery checkpoint -> mutation -> restore preview on synthetic archives, with a loopback sentinel that fails on any non-GET or unapproved request. The monitoring UI now takes a validated port (default 7125; integer 1-65535, server-side check unchanged). Mock-service-tested; no hardware.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… 11 scope; capture refuses a visible local path

The shared host mock now records the real verb (including HEAD and OPTIONS) and a test proves the sentinel sees write verbs and unapproved paths. RECOVERY.md lists what test 11 does not cover. The recovery capture fails if the page text shows a temp or user path.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…CE, CONNECT, extensions)

Review follow-up: parse_request records any parsed request whose verb has no do_<VERB> handler before the server refuses it, so the test 11 sentinel cannot miss it; a test sends TRACE, CONNECT and an extension verb.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…orms (N3)

Masked path-labelled inputs are accepted only when computed transparent; needles add work/files dirs, /Users/, /home/ and a drive-letter pattern. Syntax-checked; capture not re-run.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Base automatically changed from feat/portfolio-integration to main November 14, 2026 18:00
DVOpenLabs added a commit that referenced this pull request Nov 14, 2026
feat: integrated Phase 2 build - Creative/Prepare (#141), cross-track recovery (#142), Lumina (#139+#143), Recovery/Passport slice
@DVOpenLabs

Copy link
Copy Markdown
Owner Author

Landed on main via #144 (merge 15a2ac3) / #140. Verified: merging this head into main produces a tree identical to main, so nothing here is lost. Branch preserved.

@DVOpenLabs DVOpenLabs closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant