Repository navigation
feat(engines): Lumina adapter and bounded CLI runner (experimental, not wired) - #139
Closed
DVOpenLabs wants to merge 4 commits into
Closed
DVOpenLabs wants to merge 4 commits into
DVOpenLabs wants to merge 4 commits into
Conversation
Review repairs: timeout/cancel return within a finite allowance even if a descendant holds the pipes; an unexpected poll exception stops the owned child; output scan refuses OSError, junction/reparse points, and is bounded (10000 entries, depth 32); script entry points refused; single-pass placeholder substitution; real loopback boundary test. Test environment note: os.kill(pid, 0) is not a liveness probe on Windows (it calls TerminateProcess and raises OSError); the test now uses a non-signalling probe. Verified: backend/tests/engines 17 passed, 1 skipped (symlink creation not permitted for this account). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…root Review R1 (Sol): the output root itself was never checked before traversal, so an engine could swap its empty output directory for a link and have outside files reported as job artifacts. The root is now checked like every entry; a non-directory root is refused as a failed scan. Verified: backend/tests/engines 18 passed, 1 skipped (symlink creation not permitted for this account). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Review M1 (Opus): the placeholder validator had the (a*)+ shape; 24 characters took 1.1 s and each two more characters quadrupled it. Validation is now linear, with a timing-bounded test. Review M2/L1/L6/P1: documented as known limits with the usability label. Verified: backend/tests/engines 19 passed, 1 skipped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This was referenced Nov 1, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental library. Not wired to any caller or UI. Not for merge.
Adds a Lumina client (discovery, preview, artifact fetch through the local-only request layer) and a bounded CLI runner for engine executables.
Label
Fixture-tested and mock-service-tested, plus one real loopback transport-boundary test. Not exercised against a real Lumina or engine. Do not describe it as "works with Lumina" or verified.
Review repairs in this branch
.bat/.cmdentry points refused; single-pass placeholder substitution; template validation is linear (the previous pattern took 1.1 s at 24 characters and quadrupled every two more).os.kill(pid, 0)is not a liveness probe there (it calls TerminateProcess and raises OSError). The test uses a non-signalling probe and keeps the "child is gone" assertion. No OS protection was bypassed.Verified
backend/tests/engines: 19 passed, 1 skipped (this account cannot create symlinks; a separate test covers the output-symlink refusal without privilege).Review
Round 1 (e284972): Opus block, Sol block (output root not checked; backtracking regex). Round 2 (f06a9e7): Opus approve-with-notes, Sol approve-with-notes.
Known limits (also in docs/internal/ENGINES.md)
Descendants can outlive a timeout (no job object/process group yet); ancestor-directory substitution and the check-then-scan race; job directories are not removed; the runner needs a policy that keeps it from running a slicer before it is wired; tests launch
sys.executable.🤖 Generated with Claude Code