Skip to content

feat(engines): Lumina adapter and bounded CLI runner (experimental, not wired) - #139

Closed
DVOpenLabs wants to merge 4 commits into
mainfrom
feat/lumina-adapter
Closed

DVOpenLabs wants to merge 4 commits into
mainfrom
feat/lumina-adapter

Conversation

@DVOpenLabs

Copy link
Copy Markdown
Owner

Experimental library. Not wired to any caller or UI. Not for merge.

Adds a Lumina client (discovery, preview, artifact fetch through the local-only request layer) and a bounded CLI runner for engine executables.

Label

Fixture-tested and mock-service-tested, plus one real loopback transport-boundary test. Not exercised against a real Lumina or engine. Do not describe it as "works with Lumina" or verified.

Review repairs in this branch

  • Timeout/cancel return within a finite allowance even when a descendant holds the pipes; an unexpected poll exception stops the owned child.
  • Output scan refuses OSError, links, junctions and reparse points (entries and the output root), with finite bounds (10000 entries, depth 32).
  • .bat/.cmd entry points refused; single-pass placeholder substitution; template validation is linear (the previous pattern took 1.1 s at 24 characters and quadrupled every two more).
  • Windows test environment: os.kill(pid, 0) is not a liveness probe there (it calls TerminateProcess and raises OSError). The test uses a non-signalling probe and keeps the "child is gone" assertion. No OS protection was bypassed.

Verified

backend/tests/engines: 19 passed, 1 skipped (this account cannot create symlinks; a separate test covers the output-symlink refusal without privilege).

Review

Round 1 (e284972): Opus block, Sol block (output root not checked; backtracking regex). Round 2 (f06a9e7): Opus approve-with-notes, Sol approve-with-notes.

Known limits (also in docs/internal/ENGINES.md)

Descendants can outlive a timeout (no job object/process group yet); ancestor-directory substitution and the check-then-scan race; job directories are not removed; the runner needs a policy that keeps it from running a slicer before it is wired; tests launch sys.executable.

🤖 Generated with Claude Code

DVOpenLabs and others added 3 commits October 31, 2026 13:51
Review repairs: timeout/cancel return within a finite allowance even if a descendant holds
the pipes; an unexpected poll exception stops the owned child; output scan refuses OSError,
junction/reparse points, and is bounded (10000 entries, depth 32); script entry points refused;
single-pass placeholder substitution; real loopback boundary test.
Test environment note: os.kill(pid, 0) is not a liveness probe on Windows (it calls
TerminateProcess and raises OSError); the test now uses a non-signalling probe.

Verified: backend/tests/engines 17 passed, 1 skipped (symlink creation not permitted for this account).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…root

Review R1 (Sol): the output root itself was never checked before traversal, so an engine could
swap its empty output directory for a link and have outside files reported as job artifacts.
The root is now checked like every entry; a non-directory root is refused as a failed scan.

Verified: backend/tests/engines 18 passed, 1 skipped (symlink creation not permitted for this account).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Review M1 (Opus): the placeholder validator had the (a*)+ shape; 24 characters took 1.1 s and
each two more characters quadrupled it. Validation is now linear, with a timing-bounded test.
Review M2/L1/L6/P1: documented as known limits with the usability label.

Verified: backend/tests/engines 19 passed, 1 skipped.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

DVOpenLabs added a commit that referenced this pull request Nov 14, 2026
feat: integrated Phase 2 build - Creative/Prepare (#141), cross-track recovery (#142), Lumina (#139+#143), Recovery/Passport slice
@DVOpenLabs

Copy link
Copy Markdown
Owner Author

Landed on main via #144 (merge 15a2ac3) / #140. Verified: merging this head into main produces a tree identical to main, so nothing here is lost. Branch preserved.

@DVOpenLabs DVOpenLabs closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant