Repository navigation
feat(prepare): lay multi-plate projects from larger printers onto the U1 plate grid #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
24105e4
feat(prepare): per-plate regrid, prime-tower placement, kept support …
DVOpenLabs 3f01ecf
fix(prepare): tower assessed not moved; support-intent precedence; ma…
DVOpenLabs 6030404
fix(prepare): update obsolete painted-support and multi-plate wording…
DVOpenLabs bf2d10d
fix(prepare): address review findings on the re-grid and support disc…
DVOpenLabs a063c12
fix(prepare): close the final-review findings on the re-grid and towe…
DVOpenLabs acdbfc5
fix(prepare): tower disclosure follows where the tower position came …
DVOpenLabs bea0125
Merge remote-tracking branch 'origin/main' into feat/multi-plate-regrid
DVOpenLabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exclude CDATA sections when counting root-model items.
rewrite_items_by_indexskips only XML comments._ITEM_TAG_REstill matches tag-shaped text inside a CDATA section. For example,<![CDATA[<item objectid="1"/>]]>in root-model text is counted as a build item. It consumes an ordinal and can receive an offset meant for a real build item. The real item then keeps its position, or it receives another instance's translation.The guard in
backend/snapstudio_core/regrid.pydoes not detect this. It compares item counts, non-transformattributes, andmovedagainstlen(offsets). It does not compare the translation values of the build items.Exclude CDATA spans with the comment spans:
Suggested fix
A single alternation scans left to right. A
<!--inside a CDATA section therefore cannot start a comment span that hides real build items. Update the docstring to say that comments and CDATA text are not items. If_COMMENT_REhas other references, keep it and add the alternation as a separate pattern.