Skip to content

Add COALESCE function to trino language#214

Open
stavby wants to merge 3 commits into
DTStack:mainfrom
stavby:patch-1
Open

Add COALESCE function to trino language#214
stavby wants to merge 3 commits into
DTStack:mainfrom
stavby:patch-1

Conversation

@stavby
Copy link
Copy Markdown

@stavby stavby commented Apr 30, 2026

Added 'COALESCE' function to the list of supported built in functions in trino and corrected spelling errors in comments.

Added 'COALESCE' function to the list of supported built in functions  in trino and corrected spelling errors in comments.
@nickBes
Copy link
Copy Markdown

nickBes commented May 14, 2026

oh that's why we don't have coalesce in our editor 🤯
when is this merged??

@liuxy0551
Copy link
Copy Markdown
Collaborator

First of all, thank you for your PR. I have a few more questions.

Do you want COALESCE to be highlighted as a function (like CONCAT), or do you want it to appear as a suggestion in code completion?

Additionally, Not support is also used in other files. We will address this in a separate PR to change it to Not supported, so please don't include that spelling change in the current PR.

@liuxy0551 liuxy0551 self-requested a review May 15, 2026 13:53
@stavby
Copy link
Copy Markdown
Author

stavby commented May 17, 2026

@liuxy0551

First of all, thank you for your PR. I have a few more questions.

Do you want COALESCE to be highlighted as a function (like CONCAT), or do you want it to appear as a suggestion in code completion?

Additionally, Not support is also used in other files. We will address this in a separate PR to change it to Not supported, so please don't include that spelling change in the current PR.

Fixed.
And I want both - so it'll be highlighted as a function and also be suggested by the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants