Gsm v2 - #111
Closed
emuskardin wants to merge 73 commits into
Closed
Gsm v2#111emuskardin wants to merge 73 commits into
emuskardin wants to merge 73 commits into
Conversation
…initial output for Moore
emuskardin
requested review from
zwergziege
and removed request for
zwergziege
September 9, 2026 17:00
zwergziege
reviewed
Sep 11, 2026
zwergziege
reviewed
Sep 11, 2026
zwergziege
reviewed
Sep 11, 2026
zwergziege
reviewed
Sep 11, 2026
Collaborator
|
regarding 1: since having counts for non-prefix-closed deterministic data is not all that useful, i suggest simply raising an exception if unknown_output is encountered in the data handler. if somebody really needs it, they can implement it themselves. regarding 2: i think this behavior is perfectly fine. the classic RPNI version also does not raise on None outputs. a warning maybe. |
…tomaton + fix justification for cache wipe and add todo
…naming of methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Ensure, also in tests / run exaustive that I have added, that DFA and Moore learning works also with non-prefix closed data