fix/df 1287: prevent 500s being thrown on a 404 - #1259
Merged
Conversation
alexluckett
approved these changes
Aug 13, 2026
| } | ||
|
|
||
| return yar?.get('language') ?? defaultLang | ||
| return (sessionReady && yar ? yar.get('language') : null) ?? defaultLang |
Contributor
There was a problem hiding this comment.
the yar part can move into sessionReady rather than duplicating it
Contributor
Author
There was a problem hiding this comment.
Yes, but then lint complains that yar is possibly null. I either force the Yar type (to not be null) or add the additional 'yar' in the condition - unless you can think of a better way?
Contributor
Author
There was a problem hiding this comment.
Ignore me! I understand what you mean now - resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error pages may get actioned before the Yar session has had chance to initialise fully (on PreAuth).
Therefore this defensive code is required to prevent random 404 urls (where no previous session, soperhaps from a hack attempt) throwing 500s