Repository navigation
feat: support Sylius 2.3 and Symfony 8 - #9
Merged
Merged
Conversation
Symfony 8 no longer loads the XML configuration format. Service ids, tags and arguments are unchanged; the tag attribute gateway-factory becomes gateway_factory, the key the XML loader already normalised it to.
Behat 4, the version Symfony 8 requires, only reads PHP configuration and no longer reads annotations. The Sylius suites are no longer imported: 2.3 ships them in PHP only, and the plugin suites only use the Sylius contexts.
Sylius 2.3 passes a Request instead of a RequestConfiguration to the HTTP response providers: the Axepta provider types that argument as object, which satisfies both signatures since it never reads it. The abandoned friends-of-behat Mink forks give way to behat/mink and behat/mink-browserkit-driver.
…y actions Before Sylius 2.3 the matrix keeps Behat 3 and Doctrine ORM below 3.7. PHPStan and ECS only run on the primary job, now Sylius 2.3 / PHP 8.4 / Symfony 7.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
Adds Sylius 2.3 and Symfony 8 support while keeping Sylius 2.1 / 2.2 and Symfony 6.4 / 7.4. The public contract does not move: this is meant for
v1.1.0.gateway-factorytag attribute becomesgateway_factory, the key the XML loader already normalised it to.behat.dist.php,#[Given]steps, Sylius suites no longer imported. The abandoned friends-of-behat Mink forks give way tobehat/mink.Requestinstead of aRequestConfigurationtoHttpResponseProviderInterface(UPGRADE-2.3, item 4).AxeptaHttpResponseProvidertypes that unused argument asobject, which satisfies both signatures.contents: read.homepage,authorsandsupportincomposer.json; the payment redirect page follows the browser colour scheme; the development stack runs PHP 8.4 and Node 22; the README banner matches the other Cyllene plugins; the docs announce the new matrix.Verified locally: unit (130), integration and functional (80), Behat (9 scenarios), PHPStan, ECS and
lint:containergreen on Sylius 2.3.0 / Symfony 8.1 / PHP 8.4, and on Sylius 2.1.16 / Symfony 6.4 / Behat 3. The back office was checked in dark mode on Sylius 2.3.Points to watch
vendor/bin/phpunit,vendor/bin/behat --strict)UPGRADE.mdis up to date if the public contract changesdescription
If the pull request touches the protocol or the cryptography
It does not: the protocol layer and the cryptography are unchanged.