Repository navigation
ci: hold webpack below 5.112 for the Sylius 2.1 front-end build - #9
Merged
JDCyllene merged 3 commits intoOct 16, 2026
Merged
Conversation
webpack 5.112.0 moved internals that the Stimulus bridge of Sylius 2.1's test application loads, and that application has no lock file: every Sylius 2.1 job fails on its front-end build. Those jobs now build it themselves, webpack held at ~5.111.0, until a webpack release loads the bridge again.
…dency A direct dependency hoisted webpack away from the CLI Encore runs it with: the Sylius 2.1 build then asked to install webpack-cli.
The test application's preinstall script rebuilds package.json from package.json.dist, which dropped the resolution: webpack 5.112 was still installed.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
webpack 5.112.0 (released 2026-10-15) moved internals that the Stimulus bridge of Sylius 2.1's test application still loads: its front-end build stops on
Cannot find module 'webpack/lib/dependencies/LoaderDependency', and that application has no lock file to hold the previous release. Every Sylius 2.1 job fails, whatever the change (seen on #8); Sylius 2.2 and 2.3 build fine.The Sylius 2.1 jobs now give
BuildTestAppActionno Node version, which makes it skip the front-end build, and build it themselves right after, with webpack held at~5.111.0. The other jobs are untouched. The comment above those steps says when to remove them: once a webpack release loads the bridge again.Points to watch
vendor/bin/phpunit,vendor/bin/behat --strict) - CI only; checked by this pull request's own runUPGRADE.mdis up to date if the public surface changes (routes, Twig hooks, templates, role, menu entry, services aliased over the engine) - nothing changesdocs/adr/- none: a temporary CI workaround