Repository navigation
fix: let the burger click of the mobile menu reach the document - #9
Merged
JDCyllene merged 1 commit intoOct 14, 2026
Merged
Conversation
The mobile menu controller listened to the burger in the capture phase and stopped the event, so that Bootstrap's offcanvas could not handle it. The burger of the mega menu carries no data-bs-toggle, so Bootstrap never handled it, while stopping the event hid the click from the listeners delegated on the document (analytics click triggers). The controller now listens to the burger in the bubbling phase and lets the click go on. A browser scenario opens the drawer from the burger, drills into a taxon and closes it with Escape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
In mega menu mode, the mobile menu controller listened to the burger in the capture phase and called
stopImmediatePropagation(), so that Bootstrap's offcanvas could not handle the click. The burger of the mega menu carries nodata-bs-toggle, so Bootstrap never handled it; stopping the event only hid the click from the listeners delegated on the document, such as analytics click triggers.data-action.The change ships in the shop JavaScript: shops get it with the next patch release, after rebuilding their assets.
Points to watch
vendor/bin/phpunit,vendor/bin/behat --strict)sh tests/check-schema-drift.shprints nothing (MySQL or PostgreSQL)UPGRADE.mdis up to date if the public contract changes (traits and interfaces, Twig hooks and functions, grid query)docs/adr/