Repository navigation
ci: drop the Sylius 2.3.0 workarounds now that 2.3.1 is out - #8
Merged
JDCyllene merged 1 commit intoOct 14, 2026
Merged
Conversation
Sylius 2.3.1 passes the default label and icon of the grid delete action (Sylius#19285) and recognizes MariaDB on DBAL 4 in its migrations (Sylius#19272). - symfony/ux-twig-component is no longer capped below 3.5 in require-dev: Sylius 2.1 and 2.2 require 2.x, and 2.3.1 renders the delete buttons with 3.5 and later. - The MariaDB jobs run the migrations again instead of building the schema from the mappings. - The docs restrict the MariaDB pitfall to Sylius 2.3.0 with DBAL 4 (2.1 and 2.2 stay on DBAL 3) and advise upgrading to 2.3.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
Sylius 2.3.1 passes the default label and icon of the grid delete action (Sylius#19285) and recognizes MariaDB on DBAL 4 in its migrations (Sylius#19272). The two workarounds they made necessary go away:
symfony/ux-twig-componentis no longer capped below 3.5 inrequire-dev. Sylius 2.1 and 2.2 require 2.x, so the cap only mattered for 2.3, and 2.3.1 renders the delete buttons with 3.5 and later (checked with 3.6).database_setup: schemaremoved, the action defaults to the migrations).Points to watch
vendor/bin/phpunit,vendor/bin/behat --strict), locally on Sylius 2.3.1 / MySQL platform; the MariaDB migrations are validated by this CIsh tests/check-schema-drift.shprints nothing (MySQL or PostgreSQL)UPGRADE.mdis up to date if the public contract changes (traits and interfaces, Twig hooks and functions, grid query)docs/adr/CI, development requirements and docs only: nothing changes in what a shop installs, no release needed.