Repository navigation
ci: test application built with stimulus-bridge 4.0.2 - #10
Merged
Merged
Conversation
webpack 5.112 removed webpack/lib/dependencies/LoaderDependency, which the
@symfony/stimulus-bridge 3.x loader requires on load: the Sylius 2.1 test
application front build fails on it ("Cannot find module"). Version 4.0.2
takes the module factory from the compilation instead.
The test application merges tests/TestApplication/package.json into its own
before yarn install, so the plugin raises the bridge there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
Since webpack 5.112.0, the Sylius 2.1 jobs fail in "Build Sylius Test Application" (scheduled run of October 17):
Cannot find module 'webpack/lib/dependencies/LoaderDependency'. That webpack release moved this internal module, which the@symfony/stimulus-bridge3.x loader requires on load. The Sylius 2.1 test application takes the bridge in^3.2.0without a lockfile, and its bundles let webpack float (^5.72); Sylius 2.2 caps webpack below 5.109, so it is not affected.@symfony/stimulus-bridge4.0.2 takes the module factory from the compilation instead (symfony/stimulus-bridge#123). The test application mergestests/TestApplication/package.jsoninto its ownpackage.jsonbeforeyarn install: the plugin raises the bridge to^4.0.2there.CLAUDE.mdrecords it among the known pitfalls.Points to watch
vendor/bin/phpunit,vendor/bin/behat --strict): validated by this CI; locally, the test application front build passes on Sylius 2.3 with the bridge 4.0.2sh tests/check-schema-drift.shprints nothing (MySQL or PostgreSQL)UPGRADE.mdis up to date if the public contract changes (traits and interfaces, Twig hooks and functions, grid query)docs/adr/CI and docs only (
tests/is not in the Composer archive): nothing changes in what a shop installs, no release needed.