Conversation
The pending salary request card was labelled "Gross Salary Requested" but rendered the HCM current salary, which is the person's existing payroll amount and unrelated to the request they submitted. Fetch `calculations.requestedGross` on the latest salary request and render that instead. This is the same server-computed field the "Gross Requested Salary" total row of RequestSummaryCard uses, so the landing card and the request itself can no longer disagree. Also orient the latest calculation to the user's perspective before reading its amounts, as the landing page already does for the effective calculation. Without this, a request created by the spouse showed the spouse's figures.
Contributor
Bundle sizes [mpdx-react]Compared against 9a37cac No significant changes found |
dr-bizz
added
On Staging
Contributor
|
Preview branch generated at https://pending-salary-request.d3dytjb8adxkk5.amplifyapp.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to MPDX-10017.
In this PR, I fix the incorrect gross salary requested on the pending request card. The card was rendering the current gross salary amount instead of the newly requested salary.
I have changed it to use the newly requested salary. I have also updated it to show the user's request gross salary and their spouses' request gross salary (if they have a spouse)
Testing
Testing instructions are in https://jira.cru.org/browse/MPDX-10017
Checklist:
/quality:agent-reviewcommand locally and fixed any relevant suggestions🤖 Generated with Claude Code