Skip to content

[MPDX-9996] - Refresh NSO housing options and explain each one - #2051

Merged
wjames111 merged 4 commits into
mainfrom
MPDX-9996
Sep 21, 2026
Merged

wjames111 merged 4 commits into
mainfrom
MPDX-9996

Conversation

@wjames111

@wjames111 wjames111 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Description

Refreshes the New Staff Orientation housing options and adds a short explanation under each one so new staff can tell which situation applies to them.

  • Updated the housing option wording per the ticket (for example "Sharing 2 in hotel/suite dorm room" and "Virtual / Local / Commuting"). The labels come from a shared helper, so the questionnaire, its summary, and the Goal Settings housing dropdown all update together.
  • Each radio option in the NSO Questionnaire now shows a one-line description in small grey text underneath its label. Screen readers get the label as the option's name and the description via aria-describedby.
  • Kept "Married couple" and "Family" as separate options because the API stores them as separate values with different room costs. Both share the ticket's "staying together as a couple or family" description.

Jira: MPDX-9996

Testing

  • Go to HR Tools and open the NSO MPD Questionnaire
  • Go to the NSO Information step
  • Check that each housing option shows the new wording with a grey explanation underneath
  • Open a New Staff Goal Calculation's Goal Settings and check the Housing dropdown uses the same new wording

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /quality:agent-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@wjames111 wjames111 self-assigned this Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Bundle sizes [mpdx-react]

Compared against a600f11

No significant changes found

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Preview branch generated at https://MPDX-9996.d3dytjb8adxkk5.amplifyapp.com

@wjames111 wjames111 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary for MPDX-9996 (senior level, review-only):

  • Wording refresh and per-option descriptions are wired through the shared housing helper, so questionnaire, summary, and Goal Settings stay consistent.
  • Accessibility is handled well: label stays the radio's name, description is linked via aria-describedby, with tests covering both.
  • No must-fix issues. Tests, lint, and tsc pass.
  • Reuse: CreateGoalDialog already renders the same labelled radio-with-description markup; worth a shared component.
  • Minor: no vertical gap between multi-line options; the 'each option' test only asserts two descriptions.
  • Scope check: the Goal Settings dropdown gets the new labels but not the descriptions, and couple/family share one description.

Comment thread src/components/HrTools/NsoMpdQuestionnaire/Shared/RadioQuestion.tsx Outdated
Comment thread src/components/HrTools/NsoMpdQuestionnaire/Shared/RadioQuestion.tsx Outdated
Comment thread src/components/HrTools/NsoMpdQuestionnaire/NsoInformation/NsoDetails.test.tsx Outdated
case NewStaffQuestionnaireNsoHousingEnum.SharedRoom:
return t('You have a roommate, or your own bedroom in a shared suite.');
case NewStaffQuestionnaireNsoHousingEnum.CoupleRoom:
case NewStaffQuestionnaireNsoHousingEnum.FamilyRoom:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Pattern] Couple and family have distinct labels and API costs but share one description. Worth confirming with the reporter whether Family should get its own wording.

* Explains what each New Staff Orientation housing option means, shown under
* the option's label to help new staff pick the right one.
*/
export const getLocalizedNsoHousingDescription = (

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Pattern] The Goal Settings housing dropdown (NsoInformationSection) picks up the new labels but not these descriptions. The ticket says 'underneath each option'; confirm whether the dropdown is in scope or questionnaire-only.

@wjames111
wjames111 requested a review from frett September 17, 2026 16:46
@wjames111
wjames111 merged commit 7a37257 into main Sep 21, 2026
23 of 24 checks passed
@wjames111
wjames111 deleted the MPDX-9996 branch September 21, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants