Conversation
Contributor
Bundle sizes [mpdx-react]Compared against a600f11 No significant changes found |
Contributor
|
Preview branch generated at https://MPDX-9996.d3dytjb8adxkk5.amplifyapp.com |
wjames111
commented
Sep 17, 2026
wjames111
left a comment
Contributor
Author
There was a problem hiding this comment.
Review summary for MPDX-9996 (senior level, review-only):
- Wording refresh and per-option descriptions are wired through the shared housing helper, so questionnaire, summary, and Goal Settings stay consistent.
- Accessibility is handled well: label stays the radio's name, description is linked via aria-describedby, with tests covering both.
- No must-fix issues. Tests, lint, and tsc pass.
- Reuse: CreateGoalDialog already renders the same labelled radio-with-description markup; worth a shared component.
- Minor: no vertical gap between multi-line options; the 'each option' test only asserts two descriptions.
- Scope check: the Goal Settings dropdown gets the new labels but not the descriptions, and couple/family share one description.
| case NewStaffQuestionnaireNsoHousingEnum.SharedRoom: | ||
| return t('You have a roommate, or your own bedroom in a shared suite.'); | ||
| case NewStaffQuestionnaireNsoHousingEnum.CoupleRoom: | ||
| case NewStaffQuestionnaireNsoHousingEnum.FamilyRoom: |
Contributor
Author
There was a problem hiding this comment.
[Pattern] Couple and family have distinct labels and API costs but share one description. Worth confirming with the reporter whether Family should get its own wording.
| * Explains what each New Staff Orientation housing option means, shown under | ||
| * the option's label to help new staff pick the right one. | ||
| */ | ||
| export const getLocalizedNsoHousingDescription = ( |
Contributor
Author
There was a problem hiding this comment.
[Pattern] The Goal Settings housing dropdown (NsoInformationSection) picks up the new labels but not these descriptions. The ticket says 'underneath each option'; confirm whether the dropdown is in scope or questionnaire-only.
frett
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refreshes the New Staff Orientation housing options and adds a short explanation under each one so new staff can tell which situation applies to them.
Jira: MPDX-9996
Testing
Checklist:
/quality:agent-reviewcommand locally and fixed any relevant suggestions