[MPDX-10001] - Show the MPD Goal admin table and NSO questionnaire only to those who need them

[wjames111]

Description

Two HR Tools menu items were showing to people who cannot use them. This narrows both.

• MPD Goal Calculator Admin Table now appears only for MPD Goals admins and MPD coordinators, using the new canViewNewStaffCohorts flag on the user instead of the Senior Staff group check. Everyone else used to see the item and then hit an authorization error from the API.
• NSO MPD Questionnaire now disappears once a new staff member has completed it, and stays hidden for anyone who has no questionnaire waiting.
• The admin table's three pages (the table, Staff Details and a scenario goal) move to the same gate, so the menu item and the pages behind it agree. A goals admin who is not Senior Staff would otherwise have landed on a Limited Access screen.

Depends on CruGlobal/mpdx_api#3625, which adds the canViewNewStaffCohorts field. CI codegen will fail here until that PR is on staging; add the Staging API label once it is.

Jira: https://jira.cru.org/browse/MPDX-10001

Testing

MPD Goal admin table:

• Sign in as a user who is neither an MPD Goals admin nor an MPD coordinator
• Open the HR Tools menu and check that "MPD Goal Calculator Admin Table" is gone
• Visit /accountLists/<id>/hrTools/mpdGoalAdmin directly and check that you get the Limited Access screen
• Sign in as an MPD Goals admin (or a coordinator) and check that the item is back and the table loads

NSO MPD Questionnaire:

• Sign in as a new staff member with an unfinished questionnaire
• Open the HR Tools menu and check that "NSO MPD Questionnaire" is listed
• Complete the questionnaire, then reopen the menu and check the item is gone while "New Staff Goal Calculator" stays

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /quality:agent-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

🤖 Generated with Claude Code

[wjames111]

Review of MPDX-10001 (senior level). The gating swap itself is clean: canViewNewStaffCohorts replaces a group check that never matched the API's own rule, and moving the three admin pages onto the same gate keeps the menu item and its destination in agreement. Two issues with the questionnaire half:

• A failed NewStaffQuestionnaireStatus query silently hides the questionnaire item from new staff who still owe one, with no error shown.
• Folding questionnaireLoading into the hook's returned loading hides the entire HR Tools tab and menu for new staff while that one query is in flight, because useNavPages gates the whole tab on it.

Both have the same fix shape: scope the questionnaire query's loading and error state to the questionnaire item rather than to the whole hook.

Everything else checked clean: developer bypass still short-circuits every gate, the skip condition correctly waits for the user before deciding, the new useMemo deps are complete, no missing localisation (no new user-visible strings), and the nav hook's new useAccountListId() dependency is safe because both callers already require one.

[github-actions]

Preview branch generated at https://MPDX-10001.d3dytjb8adxkk5.amplifyapp.com

[wjames111]

Holding the On Staging label off for now. GetUser is an app-wide query, so requesting canViewNewStaffCohorts against a staging API that does not have the field yet fails the whole query and degrades every page, not just the two menu items. Ready to go on staging as soon as CruGlobal/mpdx_api#3625 is deployed there.

Staging API and Preview Environment are on, so CI codegen will go green at the same moment.

Posted by Claude Code.

[github-actions]

Bundle sizes [mpdx-react]

Compared against 60c41be

No significant changes found