GT-3108 Consolidate AccountLayout Paparazzi tests to full-screen snapshots - #4593
Open
tjohnson009 wants to merge 1 commit into
Conversation
…shots Replaces the header-only AccountLayout snapshots with full-screen snapshots of the assembled Account screen, now possible since the screen renders from a plain UiState (GT-3107). - AccountLayoutPaparazziTest now renders the entire AccountLayout across the standard device/night/accessibility matrix: default Activity tab, Global Activity tab, drawer open, and no-user states - Add an internal @VisibleForTesting AccountLayout overload accepting a PagerState so tests can snapshot the Global Activity tab in situ - Fold GlobalActivityLayoutPaparazziTest into the full-screen Global Activity tab snapshot and remove its goldens - Keep AccountActivityBadgesPaparazziTest as a component test since it visualizes distinct badge progress states - Revert AccountLayoutHeader to private and remove stale header goldens Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mm8jFZh3uaPNENLcbnuxow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves GT-3108
Consolidates the Account screen's Paparazzi coverage to full-screen snapshots of the assembled
AccountLayout, now possible since the screen renders from a plainUiState(GT-3107). Follow-up from the review of #4583.Changes
AccountLayoutPaparazziTestnow renders the entireAccountLayoutacross the standardDeviceConfigProvider×NightMode×AccessibilityModematrix (same asToolDetailsLayoutPaparazziTest), covering: default Activity tab, Global Activity tab selected, drawer open, and signed-in-but-empty user. Sample data is deterministic — populated activity counters light up both the stat cards and badges, global activity numbers are fixed, andYearis pinned to 2025.AccountLayoutgained aninternal @VisibleForTestingoverload accepting aPagerState, the minimal hook needed to snapshot the Global Activity tab in situ (mirroring how the old header test controlled the pager). The@CircuitInjectentry point keeps its(state, modifier)signature and just delegates.GlobalActivityLayoutPaparazziTestremoved — its exact content now appears in the full-screen Global Activity tab snapshot.AccountActivityBadgesPaparazziTestkept as a component-state test per the review discussion on GT-2786 Replace deprecated TabRow with SecondaryTabRow #4583: its All Incomplete / Some Complete / All Complete badge states can't all appear in one full-screen snapshot.AccountLayoutHeaderreverted toprivateand the header-only goldens removed.Snapshots
The 20 new full-screen goldens were recorded via the Record Snapshots workflow and folded into this commit; the 11 stale header/global-activity goldens are removed.
verifyPaparazzipasses locally against the recorded goldens.🤖 Generated with Claude Code
https://claude.ai/code/session_01Mm8jFZh3uaPNENLcbnuxow