Repository navigation
Translate va_list references and pointers - #522
Merged
Merged
Conversation
lucic71
changed the title
nunoplopes
reviewed
Oct 10, 2026
| args: &'a [VaArg], | ||
| #[derive(Clone, Default)] | ||
| pub struct VaList { | ||
| args: Rc<[VaArg]>, |
Contributor
There was a problem hiding this comment.
Rc seems wrong as it may extend the lifetime of objects? Should it be Weak?
Contributor
Author
There was a problem hiding this comment.
You are right. After applying your suggestion I realised that we can transform VaList into a Ptr<VaArg>. That makes sure the lifetime is not extended and uses the existing infrastructure.
nunoplopes
reviewed
Oct 10, 2026
| pub fn sum_0(n: i32, __args: &[VaArg]) -> i32 { | ||
| let n: Value<i32> = Rc::new(RefCell::new(n)); | ||
| let ap: Value<VaList> = Rc::new(RefCell::new(VaList::default())); | ||
| (*ap.borrow_mut()) = VaList::new(__args); |
Contributor
There was a problem hiding this comment.
Why is this line not folded in the one above?
Contributor
Author
There was a problem hiding this comment.
First line is the declaration, second line is the call to va_start. There can be arbitrary many lines between the two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.