Repository navigation
Translate self referencing initialiser - #498
Merged
Merged
Conversation
lucic71
force-pushed
the
self-referencing
branch
from
October 8, 2026 19:50
f63adc1 to
2e920ee
Compare
Contributor
|
This is not a good nor generic solution. We should try to use |
Contributor
Author
I already thought about Rc::new_cyclic and it's not a good solution. It does not work for Inside the Rc::new_cycle closure we only have a Weak without a constructed T. This mean that we can convert I think the generic solution (for self-referencing variables and for self-referencing constructors, see #248) is:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the original issue reported in #248. Self-refrencing in constructors is not handled here.
It translates:
to:
That is, first create a default value, then assign it the self-referencing initialiser. Types that have defaults with side-effects are not supported.