feat(gradebook): keep-highest N for equal-mode tabs + pin expanded rows#8438
Open
LWS49 wants to merge 2 commits into
Open
Conversation
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view
branch
7 times, most recently
from
422b4af to
44284da
Compare
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view-pin-expanded-and-add-keep-n
branch
2 times, most recently
from
df2ffce to
95135ce
Compare
LWS49
changed the title
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view
branch
2 times, most recently
from
2d24331 to
4c71a02
Compare
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view-pin-expanded-and-add-keep-n
branch
from
95135ce to
f875efc
Compare
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view
branch
2 times, most recently
from
7d9fdb4 to
ade1ddf
Compare
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view-pin-expanded-and-add-keep-n
branch
2 times, most recently
from
d4cb3aa to
72edac9
Compare
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view
branch
2 times, most recently
from
521efed to
2efbb02
Compare
Expanding a student in the weighted gradebook now keeps that student's summary row pinned beneath the sticky header while their per-assessment breakdown is open, so the totals stay visible while scrolling the detail. The view becomes a single-open accordion (opening one student collapses any other), the focused row auto-scrolls to just under the header on expand (respecting prefers-reduced-motion), and focus stays on the expand/collapse toggle for keyboard users.
- Permit keepHighest in update_weights_params - Parse keepHighest from request and pass to bulk_update via keep_highest - Echo keepHighest in serialize_weight_updates response - Serialize keepHighest from contribution in index.json.jbuilder - Add controller tests: round-trip persist and index response - Add model tests: bulk_update persists keep_highest in equal mode
LWS49
force-pushed
the
lws49/feat-gradebook-weighted-view-pin-expanded-and-add-keep-n
branch
from
72edac9 to
07a4215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two features to the weighted gradebook view. First, instructors can configure a per-tab keep-highest limit in equal mode: after enabling it for a tab, only the top N submission ratios count toward that tab's subtotal - the rest are dropped as lowest. The limit only applies in equal mode (custom mode exposes per-assessment weights instead) and is stored as a new
gradebook_keep_highestcolumn oncourse_assessment_tabs. Second, the per-student score breakdown panel now pins to one open row at a time - expanding a second student collapses the first, keeping the table readable at scale.Design decisions
Regression prevention
Covers: keep-highest ratio selection and averaging, ties at the boundary, keepHighest > included (no drop), keepHighest=0 equality with legacy average, composition with per-assessment exclusion, dropped-vs-excluded display distinction in points and percentage modes, pin-to-one-expanded behaviour, keyboard focus retention on toggle, auto-scroll on expand,
keepHighestround-trip through the Redux reducer, model validation (non-negative integer), controller permit and serialisation.Manual testing: confirmed all scenarios above including keep-highest in equal mode, custom mode hiding the control, disabled state with one included assessment, save/reload persistence, dropped label and value rendering, and pin-expanded collapse behaviour.
Backward compat: tabs with no
gradebook_keep_highestvalue default to 0, which preserves existing averaging behaviour exactly.