Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ jobs:
- run: python -m build
- run: docker build --tag logsight-ai:${{ github.sha }} .
- run: docker run --rm logsight-ai:${{ github.sha }} health
- name: Verify installed package metadata
run: |
docker run --rm --entrypoint python logsight-ai:${{ github.sha }} -c \
"from importlib.metadata import metadata; package = metadata('logsight-ai'); assert package['Requires-Python'] == '>=3.10'; assert package['Description-Content-Type'] == 'text/markdown'"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Assert the packaged README body

When README.md is omitted from the Docker build context, setuptools can still infer Description-Content-Type: text/markdown from the .md filename in pyproject.toml and copy Requires-Python directly from that file, while warning and producing an empty long description. Consequently, both assertions pass against the behavior this commit is meant to prevent; assert that the installed metadata payload contains a known README passage so CI detects a recurrence.

Useful? React with 👍 / 👎.


security:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ WORKDIR /app
RUN pip install --upgrade pip build

# Copy project files required for the build
COPY pyproject.toml requirements.txt ./
COPY pyproject.toml requirements.txt README.md ./
COPY logsight/ logsight/

# Build the wheel
Expand Down
Loading