Repository navigation
fix(framework): make theme-inverted sections take the alt colors - #635
Merged
Merged
Conversation
The color theme scopes hung the default branch off :root.theme-default, a class nothing ever put on <html>, so theme-inverted and theme-always-alt never matched on published pages or in the canvas. The default branch now keys on :root:not(.theme-alt), which matches every page as rendered today and keeps a runtime toggle to the one theme-alt class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Color tokens with an alt (dark) value emit their alt scope under
:root.theme-default .theme-inverted, but nothing ever putstheme-defaulton<html>. A section withtheme-invertedortheme-always-altnever switched, on published pages or in the canvas.The fix
The default branch of the theme scopes now keys on
:root:not(.theme-alt), so it matches every page as rendered today with no extra markup. A runtime toggle stays one class: addingtheme-altflips the page and every inverted section back. Sites with no dark-mode token emit no theme CSS, so their output is unchanged.Verification
New tests parse the generated CSS and check
Element.matcheson a real document, both fromgenerateFrameworkRootCssand from a published page. They fail on main and pass here.