Feat/381 centralize api error handling - #545
Open
Jessepriase wants to merge 4 commits into
Open
Conversation
- Remove _nextAddress parameter from useWalletAccountSync callbacks in EventExplorerPage and ActivityFeed. Neither caller uses the address value. Updates hook signature to () => void to match. - Replace WALLET_ADDRESS_KEY references in regression tests with the inline string 'notify-chain:wallet-address'. The constant was never declared in this version of the test file, causing TS2552 in tsc --noEmit.
Introduce listener/src/utils/api-error.ts with two exports:
- sendError(res, status, message) — the single place where all error
responses are serialised. Writes { error: string } with Content-Type
application/json. All route handlers now call this instead of
inlining res.writeHead + res.end pairs.
- ApiError — a typed Error subclass that carries an HTTP status code,
allowing catch blocks to forward errors to sendError without a
separate status lookup.
Wire sendError into every route handler:
- events-server.ts: 61 inline error responses replaced (400/401/404/
413/422/500/503). The health endpoint's { status, detail } shape and
the batch validation { valid, errors } shape are intentionally left
as-is — they are structured data responses, not error responses.
- archive-api.ts: 5 inline error responses replaced.
- template-routes.ts: 23 inline error responses replaced.
Also fix listener/package.json: duplicate script keys and a missing
comma caused npm install to fail with EJSONPARSE.
|
@Jessepriase Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #381