docs(disk-images): correct the published CDN prefix - #35
Closed
ericwang401 wants to merge 1 commit into
Closed
ericwang401 wants to merge 1 commit into
ericwang401 wants to merge 1 commit into
Conversation
The example URLs said /images/; `cofoundry.toml` sets `prefix = "templates/"` and the live registry publishes under /templates/. The paths were elided with an ellipsis, which is why a wrong prefix survived in them.
Contributor
Author
|
Closing: the docs were right and the code was wrong. Renaming the published prefix to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example disk URLs in
docs/disk-images.mdare written under/images/, butcofoundry.tomlsetsprefix = "templates/"and the live registry publishesunder
/templates/.The paths are elided with an ellipsis, so nobody could copy one and notice it
was wrong, which is how it survived. Found while building Convoy's importer
against the real registry.
One line each, no behaviour change.