feat(helm): add disabled-by-default embeddings module - #18
Open
kkopanidis wants to merge 4 commits into
Open
kkopanidis wants to merge 4 commits into
kkopanidis wants to merge 4 commits into
Conversation
Wire optional embeddings onto generic service templates so it can be enabled after a compatible image exists, without deleting vector data on rollback.
Remove redundant embeddings values/comments, defensive port coalesces, and the long operator runbook so the module matches surrounding chart conventions without changing rendered behavior.
Reject embeddings when gRPC secrets are disabled, align default tag validation with Chart.AppVersion, and document workload versus module-config enablement plus rollback that retains vector state.
Drop leftover tutorial phrasing from embeddings README, NOTES, and values comments without changing chart behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.embeddings.enabled(defaultfalse) deploys the embeddings Kubernetes workload only. It is not the embeddings module-configenabledflag that starts generation or search workers.The workload uses gRPC 55165 and metrics 9192. Generic
install.*templates now honor per-modulecontainerPortandmetrics.service, so those ports do not collide with global 5000/9100. Enabling the workload requiresglobal.secret.grpc_enable=true(GRPC_KEY); the chart fails otherwise.Set
install.embeddings.enabled=trueonly after a publishedconduitplatform/embeddingsimage exists atinstall.embeddings.image.tag(defaults toglobal.image.tag). ChartappVersiondoes not mean that image exists.install.embeddings.enabled: falseremoves the Deployment/Service; vector fields, indexes, embedding configs, and Redis queue state stay.Depends on: ConduitPlatform/Conduit#1592 — merge Conduit first, then this chart.
Test plan
helm lint charts/conduit --set loki.setup=false --set prometheus.setup=falsehelm template: no embeddings Deployment/Service, no ports 55165/9192--set install.embeddings.enabled=true: embeddings gRPC 55165, metrics 9192,GRPC_KEYmounted,METRICS_PORT=9192--set install.embeddings.enabled=true --set global.secret.grpc_enable=falsefailsinstall.*modules still render gRPC 5000 / metrics 9100install.embeddings.enabled=trueonly after a published embeddings image exists at the selected tag; keep module-config workers off until the pod is runninginstall.embeddings.enabled=falseand confirm Deployment/Service are gone while vector fields, indexes, embedding configs, and Redis state remain