fix(logs): keep the logs console in-panel with latest-first rows - #333
Open
JohnChantz wants to merge 5 commits into
Open
JohnChantz wants to merge 5 commits into
JohnChantz wants to merge 5 commits into
Conversation
Bound drawer and viewer scrolling to one flex viewport, and wire search into Loki so the sheet can expand without stretching.
Give the snap drawer a real height, drag only from the handle, and absolutely position the list viewport so it no longer grows with rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
masterbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Summary
The bottom logs sheet used to grow past its snap height: long messages stretched the panel, expanded JSON had no horizontal bound, and the search box only updated the URL. Operators now get a diagnostics console that stays inside the drawer (and the full Logs Viewer page), with search actually querying Loki.
Latest entries are listed first. The list follows new entries only while you are already at the top; scrolling down or expanding a row keeps your place, with a Jump to latest control when you leave the head. Collapsed HTTP rows show method, path, status, and duration so you can scan without opening every line. Loki failures surface as retryable errors instead of a silent empty list. The drawer no longer writes filter params onto module routes; only
/logs-viewersyncs the URL.Test plan
/logs-viewer, apply filters, reload, and confirm the query string is restored.pnpm lint(0 errors on these files),pnpm test:logs-viewer, andpnpm buildpassed. Authenticated click-through of the live drawer was not completed from this session.Other information:
Targets
ui-rewriteso this stays on the current admin rewrite rather thanmain.