You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Connector PR Review: only emit highest permission for repo
Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review mode: full View review run
Review Summary
Reviewed the repository grant logic change that collapses GitHub's cumulative permission maps into a single highest-level grant for user, team, and org-expansion paths, plus the corresponding mock update. The new highestRepoPermission helper iterates repoAccessLevels from highest to lowest and returns the first level set, which is correct given GitHub reports every level at or below a principal's access as true and the repository entitlements share an exclusion group. The change also fixes a latent bug where the previous per-key loop could emit grants for unrecognized permission keys (e.g. the old permission0 mock value); no new issues found.
The reason will be displayed to describe this comment to others. Learn more.
No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.