Skip to content

[CE-784] Only emit highest permision for repo#176

Open
MarcusGoldschmidt wants to merge 1 commit into
mainfrom
goldschmidt/highest-repo-permission
Open

[CE-784] Only emit highest permision for repo#176
MarcusGoldschmidt wants to merge 1 commit into
mainfrom
goldschmidt/highest-repo-permission

Conversation

@MarcusGoldschmidt

Copy link
Copy Markdown
Contributor

No description provided.

@MarcusGoldschmidt MarcusGoldschmidt requested a review from a team June 15, 2026 15:15
@linear-code

linear-code Bot commented Jun 15, 2026

Copy link
Copy Markdown

CE-784

@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: only emit highest permission for repo

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

Reviewed the repository grant logic change that collapses GitHub's cumulative permission maps into a single highest-level grant for user, team, and org-expansion paths, plus the corresponding mock update. The new highestRepoPermission helper iterates repoAccessLevels from highest to lowest and returns the first level set, which is correct given GitHub reports every level at or below a principal's access as true and the repository entitlements share an exclusion group. The change also fixes a latent bug where the previous per-key loop could emit grants for unrecognized permission keys (e.g. the old permission0 mock value); no new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant