Skip to content

feat(pages): widgets on the application start page (step 6, separable) - #51

Open
rubenvdlinde wants to merge 1 commit into
stack/r5-page-technical-namesfrom
stack/r6-start-page-widgets
Open

rubenvdlinde wants to merge 1 commit into
stack/r5-page-technical-namesfrom
stack/r6-start-page-widgets

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Collaborator

Step 6 of the page rework (follows the review on nextcloud#3075). Our own ask on top of nextcloud#3100 / nextcloud#3099, kept separate so upstream can leave it out. Stacked on #50.

What

  • PATCH /api/2/contexts/{contextId}/pages/{pageId} accepts widgets for the start page as well (step 2 refused them). The start page's tables and views (page_content) are untouched; deleting the start page is still a 400.
  • The start page renders the same grid and edit mode above its tables and views. Without widgets it looks as before; people who manage the application see only an "Edit page" button there.

Tests

  • tests/unit/Service/PageServiceTest.php: OK (32 tests, 89 assertions) (start page widgets synced, page content untouched)
  • whole unit suite: OK (445 tests, 907 assertions)
  • npx playwright test playwright/e2e/context-grid-pages.spec.ts --timeout=120000 (1600 px): 7 passed (1.7m), incl. a header added to the start page shown above its table after a reload, and the read-only sharee seeing it without an edit button.
  • Existing context.spec.ts + context-navigation.spec.ts: 8 passed (4.5m).
  • composer cs:check: no files; psalm: no errors; npm run lint: 0 errors, 1 inherited warning (src/store/store.js:176); npm run stylelint: clean; OpenAPI regenerated (description only).

Prepared in the Conduction fork for porting upstream by @remko48. Prepared with Claude Code.

The start page can hold widgets too: the same grid and edit mode as a
grid page, shown above the start page's tables and views. Without
widgets the start page looks as before, with only an "Edit page" button
for people who manage the application.

Separate from nextcloud#3100 so it can be left out upstream.

Assisted-by: ClaudeCode:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant