Skip to content

chore(coverage): ratchet baseline 29.6 -> 29.69 (measured) - #749

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/coverage-baseline-29-69
Open

chore(coverage): ratchet baseline 29.6 -> 29.69 (measured)#749
rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/coverage-baseline-29-69

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Coverage Baseline Check is push-only and runs coverage-guard.php --update-baseline, then fails on a non-empty git diff -- .coverage-baseline. A baseline that is too LOW therefore fails exactly as hard as one that is too high.

Coverage baseline: 29.6%
Coverage current:  29.69%

Measured on development push run 31074667383.

This is a genuine improvement rather than measurement noise: the two preceding push runs, 31049337245 and 31041326272, both measured exactly 29.6 and passed. Coverage moved with the code committed in between.

Caveat, stated honestly: this is a single measurement at the new value. If development churns further before this merges, the guard can move again and this PR will need refreshing — that is inherent to a ratchet pinned to a measured figure, not a defect in this change.

This raises the baseline, which is what the job's own error text asks for: "The Coverage Baseline Protection job accepts any value that does not LOWER the baseline." No threshold weakened, no waiver, no skip.

Coverage Baseline Check measured 29.69% on development push run 31074667383
while .coverage-baseline said 29.6, so the job failed on the non-empty git diff
left by --update-baseline.

This is a genuine improvement, not a wobble: runs 31049337245 and 31041326272
both measured exactly 29.6, so coverage moved with the code in between.

Raises the baseline to the measured value, as the job's own error text asks.
No threshold weakened, no waiver.
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/procest @ 313b8ae

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue3-compile
test-l10n
composer ✅ 100/100
npm ✅ 550/550
PHPUnit
Newman ⏭️
Playwright
Hydra gates

Quality workflow — 2026-08-06 06:29 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Heads-up from the ratchet fix (ConductionNL/.github#181, merged): the job this PR closes no longer exists.

Coverage Baseline Check failed when the committed value was stale — i.e. when coverage had gone up. That, together with the phpunit guard failing when coverage went down, demanded exact equality with a checked-in constant, which against a moving base branch is not satisfiable. Six of sixteen apps were red on it simultaneously, every one for coverage being higher than recorded, three of them by 0.01–0.02%.

The ratchet now measures the merge base on pull requests and compares against that, so the floor cannot go stale and there is nothing for anyone to keep up to date. The push-side staleness job is deleted. .coverage-baseline remains only as a conservative fail-safe floor on pushes.

This PR is therefore optional, not required — nothing is red waiting on it. It is still safe to merge (raising a floor is always accepted), but it is worth knowing the trade: pinning the floor to today's exact measurement puts the push-side check back on a knife edge, where a single covered statement in either direction is once again meaningful. A floor left below actual coverage is simply conservative and is never what blocks a PR.

No action needed either way — flagging so it isn't merged under the belief that it is unblocking something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant