fix(contextchat): OCP\ContextChat is NC 33+, but this app supports NC 28+

[rubenvdlinde]

Two classes named an OCP\ContextChat type in their constructor, which is fatal on every Nextcloud below 33 — lib/public/ContextChat/ does not exist on stable31 or stable32, and appinfo/info.xml declares min-version="28".

The load happens in the container, not at class declaration: SimpleContainer::resolve() calls new ReflectionClass() on each parameter type. That call is the load.

class	how it is resolved	consequence on NC 28-32
ContextChatReindexCommand	listed in info.xml → loadCommandsFromInfoXml()	throws on every occ invocation
ContextChatSubmissionListener	ObjectCreated/Updated/Deleted events	throws on every object write

The command failure is already visible in CI on NC 31.0.14.1 during occ app:enable:
Interface "OCP\ContextChat\IContentProvider" not found — logged at level 3 while the enable still reports success. Loud in the log, invisible in the exit code, which is how it survived. The listener's docblock claimed IContentManager was "always resolvable via DI"; it is not.

Both now resolve through the container inside the method body, behind an interface_exists() guard. Both listener call sites are guarded separately — submitContentItem() and removeContentItem() each read ContentProvider:: constants, and loading that class is fatal too, since its header implements the missing interface.

ContentProviderRegistrationListener is deliberately unchanged: it is only ever resolved by dispatching ContentProviderRegisterEvent, which cannot fire without Context Chat.

Verified with a probe that simulates NC < 33

class	before	after
ContextChatReindexCommand	FATAL Interface "OCP\ContextChat\IContentProvider" not found	OK
ContextChatSubmissionListener	FATAL Class "OCP\ContextChat\IContentManager" does not exist	OK
ContentProvider (control)	FATAL	still FATAL

The control matters: it proves the probe really simulates NC < 33 rather than passing everything.

The first probe I wrote proved nothing. It read parameter types via getType()->getName(), which returns a string without loading the class — so the unfixed command "passed". The fatal only appears once each parameter type is itself reflected.

Tests — and the same hole, twice

tests/Unit/ContextChat/ContextChatVersionGuardTest.php pins the shape, since a machine where OCP\ContextChat resolves cannot reproduce the fatal.

Its first version had the same class of hole as the probe: it checked only whether the parameter type name contained OCP\ContextChat, so re-adding ContentProvider $contentProvider to the command — the original defect, verbatim — still passed, because ContentProvider is an OCA class. It now walks class_implements()/class_parents() too.

mutation	result
re-add ContentProvider to the command's constructor	1 failure
drop one of the listener's two guards	1 failure
restored	OK (4 tests)

The existing ContextChatSubmissionListenerTest passes unchanged in substance — only the constructor wiring moved to a container mock returning the same IContentManager mock, so all 26 assertions still observe what they did before.

[github-actions]

Quality Report — ConductionNL/openregister @ 3a32f78

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	❌
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-specs		✅
test-l10n		✅
composer			✅	✅ 173/173
npm			✅	✅ 713/713
PHPUnit					✅
Newman					✅
Playwright					✅
Hydra gates					❌

---

Quality workflow — 2026-08-06 13:05 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/openregister @ 5cdad8a

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-specs		✅
test-l10n		✅
composer			✅	✅ 173/173
npm			✅	✅ 713/713
PHPUnit					✅
Newman					✅
Playwright					✅
Hydra gates					❌

---

Quality workflow — 2026-08-06 13:33 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/openregister @ 1c9a490

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-specs		✅
test-l10n		✅
composer			✅	✅ 173/173
npm			✅	✅ 713/713
PHPUnit					✅
Newman					✅
Playwright					✅
Hydra gates					✅

---

Quality workflow — 2026-08-06 13:52 UTC

Download the full PDF report from the workflow artifacts.